chore(usePopper): Migrate react-positioning to new DX#18586
Merged
ling1726 merged 4 commits intomicrosoft:masterfrom Jun 17, 2021
Merged
chore(usePopper): Migrate react-positioning to new DX#18586ling1726 merged 4 commits intomicrosoft:masterfrom
ling1726 merged 4 commits intomicrosoft:masterfrom
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c67362c086adf01363d1bb85a4303c35852a7d6c (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 843 | 897 | 5000 | |
| BaseButton | mount | 978 | 964 | 5000 | |
| Breadcrumb | mount | 2620 | 2697 | 1000 | |
| ButtonNext | mount | 545 | 543 | 5000 | |
| Checkbox | mount | 1667 | 1640 | 5000 | |
| CheckboxBase | mount | 1420 | 1409 | 5000 | |
| ChoiceGroup | mount | 5163 | 5066 | 5000 | |
| ComboBox | mount | 1039 | 1165 | 1000 | |
| CommandBar | mount | 10398 | 10337 | 1000 | |
| ContextualMenu | mount | 6461 | 6475 | 1000 | |
| DefaultButton | mount | 1263 | 1180 | 5000 | |
| DetailsRow | mount | 3946 | 3927 | 5000 | |
| DetailsRowFast | mount | 3958 | 3936 | 5000 | |
| DetailsRowNoStyles | mount | 3707 | 3726 | 5000 | |
| Dialog | mount | 2198 | 2166 | 1000 | |
| DocumentCardTitle | mount | 163 | 168 | 1000 | |
| Dropdown | mount | 3519 | 3459 | 5000 | |
| FocusTrapZone | mount | 1885 | 1851 | 5000 | |
| FocusZone | mount | 1909 | 1816 | 5000 | |
| IconButton | mount | 1859 | 1948 | 5000 | |
| Label | mount | 364 | 361 | 5000 | |
| Layer | mount | 1926 | 1977 | 5000 | |
| Link | mount | 490 | 511 | 5000 | |
| MakeStyles | mount | 1813 | 1832 | 50000 | |
| MenuButton | mount | 1596 | 1567 | 5000 | |
| MessageBar | mount | 2082 | 2073 | 5000 | |
| Nav | mount | 3568 | 3493 | 1000 | |
| OverflowSet | mount | 1106 | 1128 | 5000 | |
| Panel | mount | 2193 | 2205 | 1000 | |
| Persona | mount | 921 | 884 | 1000 | |
| Pivot | mount | 1522 | 1519 | 1000 | |
| PrimaryButton | mount | 1447 | 1416 | 5000 | |
| Rating | mount | 8387 | 8724 | 5000 | |
| SearchBox | mount | 1488 | 1465 | 5000 | |
| Shimmer | mount | 2785 | 2763 | 5000 | |
| Slider | mount | 2071 | 2163 | 5000 | |
| SpinButton | mount | 5341 | 5259 | 5000 | |
| Spinner | mount | 443 | 429 | 5000 | |
| SplitButton | mount | 3321 | 3267 | 5000 | |
| Stack | mount | 548 | 541 | 5000 | |
| StackWithIntrinsicChildren | mount | 1780 | 1796 | 5000 | |
| StackWithTextChildren | mount | 5268 | 5213 | 5000 | |
| SwatchColorPicker | mount | 10804 | 10997 | 5000 | |
| Tabs | mount | 1504 | 1470 | 1000 | |
| TagPicker | mount | 2599 | 2636 | 5000 | |
| TeachingBubble | mount | 12134 | 12364 | 5000 | |
| Text | mount | 473 | 461 | 5000 | |
| TextField | mount | 1495 | 1469 | 5000 | |
| ThemeProvider | mount | 1227 | 1233 | 5000 | |
| ThemeProvider | virtual-rerender | 598 | 603 | 5000 | |
| ThemeProviderNext | mount | 6730 | 6732 | 5000 | |
| Toggle | mount | 899 | 882 | 5000 | |
| buttonNative | mount | 112 | 121 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 201 | 183 | 1.1:1 |
| CardMinimalPerf.default | 648 | 597 | 1.09:1 |
| HeaderMinimalPerf.default | 407 | 374 | 1.09:1 |
| LayoutMinimalPerf.default | 423 | 387 | 1.09:1 |
| AvatarMinimalPerf.default | 231 | 214 | 1.08:1 |
| ButtonSlotsPerf.default | 609 | 571 | 1.07:1 |
| FlexMinimalPerf.default | 312 | 293 | 1.06:1 |
| GridMinimalPerf.default | 380 | 360 | 1.06:1 |
| RefMinimalPerf.default | 255 | 242 | 1.05:1 |
| AttachmentSlotsPerf.default | 1225 | 1179 | 1.04:1 |
| IconMinimalPerf.default | 674 | 648 | 1.04:1 |
| TreeMinimalPerf.default | 890 | 859 | 1.04:1 |
| DividerMinimalPerf.default | 406 | 393 | 1.03:1 |
| ListCommonPerf.default | 678 | 657 | 1.03:1 |
| LoaderMinimalPerf.default | 719 | 698 | 1.03:1 |
| PopupMinimalPerf.default | 597 | 582 | 1.03:1 |
| PortalMinimalPerf.default | 176 | 171 | 1.03:1 |
| TableManyItemsPerf.default | 2141 | 2081 | 1.03:1 |
| TreeWith60ListItems.default | 180 | 175 | 1.03:1 |
| AnimationMinimalPerf.default | 422 | 414 | 1.02:1 |
| ChatMinimalPerf.default | 688 | 672 | 1.02:1 |
| ChatWithPopoverPerf.default | 399 | 390 | 1.02:1 |
| InputMinimalPerf.default | 1354 | 1324 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 1344 | 1317 | 1.02:1 |
| ListNestedPerf.default | 597 | 585 | 1.02:1 |
| CustomToolbarPrototype.default | 4049 | 3965 | 1.02:1 |
| AccordionMinimalPerf.default | 165 | 163 | 1.01:1 |
| AttachmentMinimalPerf.default | 164 | 163 | 1.01:1 |
| ChatDuplicateMessagesPerf.default | 325 | 322 | 1.01:1 |
| CheckboxMinimalPerf.default | 2852 | 2814 | 1.01:1 |
| HeaderSlotsPerf.default | 842 | 833 | 1.01:1 |
| ImageMinimalPerf.default | 419 | 416 | 1.01:1 |
| ProviderMinimalPerf.default | 1093 | 1082 | 1.01:1 |
| RadioGroupMinimalPerf.default | 501 | 497 | 1.01:1 |
| ReactionMinimalPerf.default | 419 | 413 | 1.01:1 |
| StatusMinimalPerf.default | 729 | 720 | 1.01:1 |
| TextMinimalPerf.default | 379 | 375 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1812 | 1805 | 1:1 |
| EmbedMinimalPerf.default | 4436 | 4423 | 1:1 |
| FormMinimalPerf.default | 463 | 465 | 1:1 |
| MenuMinimalPerf.default | 892 | 892 | 1:1 |
| MenuButtonMinimalPerf.default | 1705 | 1706 | 1:1 |
| SegmentMinimalPerf.default | 393 | 393 | 1:1 |
| SkeletonMinimalPerf.default | 389 | 388 | 1:1 |
| SplitButtonMinimalPerf.default | 4088 | 4079 | 1:1 |
| TextAreaMinimalPerf.default | 575 | 573 | 1:1 |
| ToolbarMinimalPerf.default | 1028 | 1028 | 1:1 |
| TooltipMinimalPerf.default | 1065 | 1060 | 1:1 |
| BoxMinimalPerf.default | 386 | 390 | 0.99:1 |
| DatepickerMinimalPerf.default | 5575 | 5626 | 0.99:1 |
| DropdownMinimalPerf.default | 3151 | 3192 | 0.99:1 |
| ListMinimalPerf.default | 540 | 543 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1652 | 1670 | 0.99:1 |
| SliderMinimalPerf.default | 1657 | 1675 | 0.99:1 |
| DialogMinimalPerf.default | 779 | 797 | 0.98:1 |
| DropdownManyItemsPerf.default | 718 | 736 | 0.98:1 |
| RosterPerf.default | 1271 | 1291 | 0.98:1 |
| AlertMinimalPerf.default | 297 | 306 | 0.97:1 |
| TableMinimalPerf.default | 423 | 437 | 0.97:1 |
| VideoMinimalPerf.default | 704 | 723 | 0.97:1 |
| CarouselMinimalPerf.default | 482 | 504 | 0.96:1 |
| LabelMinimalPerf.default | 399 | 418 | 0.95:1 |
| ListWith60ListItems.default | 668 | 703 | 0.95:1 |
Hotell
reviewed
Jun 16, 2021
Hotell
approved these changes
Jun 16, 2021
32 tasks
ling1726
commented
Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
(give an overview)
Focus areas to test
(optional)