Migrates react-accordion#18553
Merged
bsunderhus merged 3 commits intomicrosoft:masterfrom Jun 14, 2021
Merged
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ba3968764e8bf024872f1b90930f9829169e62ed (build) |
Hotell
reviewed
Jun 14, 2021
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 865 | 842 | 5000 | |
| BaseButton | mount | 998 | 963 | 5000 | |
| Breadcrumb | mount | 2724 | 2672 | 1000 | |
| ButtonNext | mount | 556 | 555 | 5000 | |
| Checkbox | mount | 1634 | 1686 | 5000 | |
| CheckboxBase | mount | 1427 | 1408 | 5000 | |
| ChoiceGroup | mount | 5175 | 5032 | 5000 | |
| ComboBox | mount | 1041 | 1002 | 1000 | |
| CommandBar | mount | 10388 | 10462 | 1000 | |
| ContextualMenu | mount | 6410 | 6739 | 1000 | |
| DefaultButton | mount | 1216 | 1195 | 5000 | |
| DetailsRow | mount | 4060 | 3897 | 5000 | |
| DetailsRowFast | mount | 3877 | 4000 | 5000 | |
| DetailsRowNoStyles | mount | 3748 | 3873 | 5000 | |
| Dialog | mount | 2268 | 2218 | 1000 | |
| DocumentCardTitle | mount | 159 | 152 | 1000 | |
| Dropdown | mount | 3481 | 3488 | 5000 | |
| FocusTrapZone | mount | 1838 | 1837 | 5000 | |
| FocusZone | mount | 1836 | 1895 | 5000 | |
| IconButton | mount | 1836 | 1852 | 5000 | |
| Label | mount | 350 | 338 | 5000 | |
| Layer | mount | 1907 | 1930 | 5000 | |
| Link | mount | 515 | 503 | 5000 | |
| MakeStyles | mount | 1868 | 1890 | 50000 | |
| MenuButton | mount | 1637 | 1623 | 5000 | |
| MessageBar | mount | 2157 | 2162 | 5000 | |
| Nav | mount | 3551 | 3509 | 1000 | |
| OverflowSet | mount | 1150 | 1052 | 5000 | |
| Panel | mount | 2147 | 2126 | 1000 | |
| Persona | mount | 880 | 865 | 1000 | |
| Pivot | mount | 1465 | 1487 | 1000 | |
| PrimaryButton | mount | 1437 | 1383 | 5000 | |
| Rating | mount | 8336 | 8332 | 5000 | |
| SearchBox | mount | 1408 | 1440 | 5000 | |
| Shimmer | mount | 2867 | 2825 | 5000 | |
| Slider | mount | 2155 | 2096 | 5000 | |
| SpinButton | mount | 5360 | 5280 | 5000 | |
| Spinner | mount | 414 | 449 | 5000 | |
| SplitButton | mount | 3396 | 3387 | 5000 | |
| Stack | mount | 549 | 535 | 5000 | |
| StackWithIntrinsicChildren | mount | 1680 | 1734 | 5000 | |
| StackWithTextChildren | mount | 5083 | 5077 | 5000 | |
| SwatchColorPicker | mount | 10822 | 10979 | 5000 | |
| Tabs | mount | 1509 | 1482 | 1000 | |
| TagPicker | mount | 2684 | 2602 | 5000 | |
| TeachingBubble | mount | 12327 | 12328 | 5000 | |
| Text | mount | 444 | 445 | 5000 | |
| TextField | mount | 1462 | 1507 | 5000 | |
| ThemeProvider | mount | 1223 | 1227 | 5000 | |
| ThemeProvider | virtual-rerender | 640 | 615 | 5000 | |
| ThemeProviderNext | mount | 7062 | 6738 | 5000 | |
| Toggle | mount | 842 | 865 | 5000 | |
| buttonNative | mount | 116 | 123 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Potential regressions comparing to master
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| AccordionMinimalPerf.default | 162 | 162 | 1:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonSlotsPerf.default | 635 | 574 | 1.11:1 |
| ChatDuplicateMessagesPerf.default | 334 | 309 | 1.08:1 |
| ImageMinimalPerf.default | 445 | 421 | 1.06:1 |
| HeaderSlotsPerf.default | 890 | 847 | 1.05:1 |
| ProviderMinimalPerf.default | 1100 | 1044 | 1.05:1 |
| ReactionMinimalPerf.default | 428 | 409 | 1.05:1 |
| TextMinimalPerf.default | 413 | 395 | 1.05:1 |
| GridMinimalPerf.default | 391 | 376 | 1.04:1 |
| HeaderMinimalPerf.default | 427 | 409 | 1.04:1 |
| LabelMinimalPerf.default | 450 | 432 | 1.04:1 |
| PortalMinimalPerf.default | 193 | 186 | 1.04:1 |
| SkeletonMinimalPerf.default | 398 | 383 | 1.04:1 |
| ToolbarMinimalPerf.default | 1044 | 1004 | 1.04:1 |
| AnimationMinimalPerf.default | 441 | 429 | 1.03:1 |
| CheckboxMinimalPerf.default | 2977 | 2901 | 1.03:1 |
| DatepickerMinimalPerf.default | 5828 | 5634 | 1.03:1 |
| DialogMinimalPerf.default | 832 | 811 | 1.03:1 |
| EmbedMinimalPerf.default | 4637 | 4512 | 1.03:1 |
| InputMinimalPerf.default | 1372 | 1337 | 1.03:1 |
| ListNestedPerf.default | 620 | 600 | 1.03:1 |
| RadioGroupMinimalPerf.default | 503 | 488 | 1.03:1 |
| SliderMinimalPerf.default | 1681 | 1631 | 1.03:1 |
| IconMinimalPerf.default | 710 | 690 | 1.03:1 |
| BoxMinimalPerf.default | 386 | 379 | 1.02:1 |
| DividerMinimalPerf.default | 405 | 399 | 1.02:1 |
| FlexMinimalPerf.default | 325 | 319 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 1410 | 1384 | 1.02:1 |
| ListMinimalPerf.default | 584 | 571 | 1.02:1 |
| MenuButtonMinimalPerf.default | 1770 | 1735 | 1.02:1 |
| RefMinimalPerf.default | 237 | 233 | 1.02:1 |
| SplitButtonMinimalPerf.default | 4098 | 3999 | 1.02:1 |
| TooltipMinimalPerf.default | 1089 | 1064 | 1.02:1 |
| TreeMinimalPerf.default | 883 | 866 | 1.02:1 |
| TreeWith60ListItems.default | 198 | 195 | 1.02:1 |
| AttachmentMinimalPerf.default | 177 | 175 | 1.01:1 |
| AvatarMinimalPerf.default | 216 | 213 | 1.01:1 |
| ButtonMinimalPerf.default | 192 | 191 | 1.01:1 |
| CardMinimalPerf.default | 649 | 640 | 1.01:1 |
| LoaderMinimalPerf.default | 753 | 746 | 1.01:1 |
| StatusMinimalPerf.default | 757 | 752 | 1.01:1 |
| TextAreaMinimalPerf.default | 590 | 584 | 1.01:1 |
| CustomToolbarPrototype.default | 4154 | 4110 | 1.01:1 |
| VideoMinimalPerf.default | 683 | 674 | 1.01:1 |
| AttachmentSlotsPerf.default | 1235 | 1237 | 1:1 |
| ButtonOverridesMissPerf.default | 1811 | 1816 | 1:1 |
| CarouselMinimalPerf.default | 514 | 514 | 1:1 |
| ChatMinimalPerf.default | 664 | 666 | 1:1 |
| ListCommonPerf.default | 697 | 699 | 1:1 |
| MenuMinimalPerf.default | 926 | 928 | 1:1 |
| PopupMinimalPerf.default | 599 | 599 | 1:1 |
| ChatWithPopoverPerf.default | 405 | 409 | 0.99:1 |
| DropdownMinimalPerf.default | 3259 | 3283 | 0.99:1 |
| RosterPerf.default | 1286 | 1294 | 0.99:1 |
| FormMinimalPerf.default | 462 | 471 | 0.98:1 |
| LayoutMinimalPerf.default | 407 | 416 | 0.98:1 |
| SegmentMinimalPerf.default | 372 | 378 | 0.98:1 |
| DropdownManyItemsPerf.default | 737 | 759 | 0.97:1 |
| ListWith60ListItems.default | 682 | 706 | 0.97:1 |
| TableMinimalPerf.default | 446 | 458 | 0.97:1 |
| ProviderMergeThemesPerf.default | 1672 | 1735 | 0.96:1 |
| TableManyItemsPerf.default | 2126 | 2212 | 0.96:1 |
| AlertMinimalPerf.default | 280 | 295 | 0.95:1 |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Migrates react-accordion package.