Skip to content

React aria#18550

Merged
bsunderhus merged 20 commits intomicrosoft:masterfrom
bsunderhus:react-aria
Jun 16, 2021
Merged

React aria#18550
bsunderhus merged 20 commits intomicrosoft:masterfrom
bsunderhus:react-aria

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Jun 14, 2021 •
edited
Loading

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

Introduces react-aria package to ensure reusability of base components as described by first rule of ARIA

  • Adds react-aria package

@size-auditor
Copy link

size-auditor bot commented Jun 14, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 6abe9b4670d0ff9cef0ee6fe09bf62db01d8c675 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jun 14, 2021 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 766 794 5000
BaseButton mount 859 851 5000
Breadcrumb mount 2560 2552 1000
ButtonNext mount 512 503 5000
Checkbox mount 1481 1458 5000
CheckboxBase mount 1249 1254 5000
ChoiceGroup mount 4563 4597 5000
ComboBox mount 961 927 1000
CommandBar mount 9848 9831 1000
ContextualMenu mount 6086 6078 1000
DefaultButton mount 1085 1079 5000
DetailsRow mount 3586 3571 5000
DetailsRowFast mount 3559 3589 5000
DetailsRowNoStyles mount 3368 3350 5000
Dialog mount 2097 2084 1000
DocumentCardTitle mount 130 143 1000
Dropdown mount 3143 3116 5000
FocusTrapZone mount 1709 1722 5000
FocusZone mount 1727 1724 5000
IconButton mount 1677 1694 5000
Label mount 326 328 5000
Layer mount 1697 1721 5000
Link mount 448 438 5000
MakeStyles mount 1741 1749 50000
MenuButton mount 1394 1392 5000
MessageBar mount 1950 1980 5000
Nav mount 3116 3133 1000
OverflowSet mount 985 990 5000
Panel mount 2059 2017 1000
Persona mount 805 796 1000
Pivot mount 1345 1362 1000
PrimaryButton mount 1214 1229 5000
Rating mount 7315 7325 5000
SearchBox mount 1260 1271 5000
Shimmer mount 2479 2439 5000
Slider mount 1890 1900 5000
SpinButton mount 4828 4816 5000
Spinner mount 408 398 5000
SplitButton mount 3057 3034 5000
Stack mount 478 488 5000
StackWithIntrinsicChildren mount 1441 1451 5000
StackWithTextChildren mount 4273 4337 5000
SwatchColorPicker mount 9857 9845 5000
Tabs mount 1349 1373 1000
TagPicker mount 2350 2364 5000
TeachingBubble mount 11522 11593 5000
Text mount 398 395 5000
TextField mount 1319 1330 5000
ThemeProvider mount 1151 1154 5000
ThemeProvider virtual-rerender 594 594 5000
ThemeProviderNext mount 6863 6990 5000
Toggle mount 804 795 5000
buttonNative mount 111 112 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 201 184 1.09:1
TreeWith60ListItems.default 170 159 1.07:1
ButtonMinimalPerf.default 170 161 1.06:1
ListNestedPerf.default 538 509 1.06:1
DropdownManyItemsPerf.default 663 633 1.05:1
HeaderMinimalPerf.default 347 331 1.05:1
ImageMinimalPerf.default 370 351 1.05:1
BoxMinimalPerf.default 339 325 1.04:1
ButtonSlotsPerf.default 560 538 1.04:1
ChatMinimalPerf.default 608 583 1.04:1
ChatWithPopoverPerf.default 354 341 1.04:1
DividerMinimalPerf.default 354 343 1.03:1
FormMinimalPerf.default 397 384 1.03:1
GridMinimalPerf.default 334 325 1.03:1
ItemLayoutMinimalPerf.default 1241 1201 1.03:1
LayoutMinimalPerf.default 360 351 1.03:1
TableManyItemsPerf.default 1825 1779 1.03:1
AttachmentMinimalPerf.default 146 143 1.02:1
AttachmentSlotsPerf.default 1119 1094 1.02:1
ButtonOverridesMissPerf.default 1648 1619 1.02:1
DialogMinimalPerf.default 740 728 1.02:1
LabelMinimalPerf.default 379 372 1.02:1
ListCommonPerf.default 606 592 1.02:1
PopupMinimalPerf.default 560 551 1.02:1
RadioGroupMinimalPerf.default 432 423 1.02:1
ReactionMinimalPerf.default 366 358 1.02:1
RefMinimalPerf.default 227 222 1.02:1
SkeletonMinimalPerf.default 340 334 1.02:1
TreeMinimalPerf.default 779 763 1.02:1
VideoMinimalPerf.default 599 586 1.02:1
CardMinimalPerf.default 533 526 1.01:1
EmbedMinimalPerf.default 4007 3974 1.01:1
InputMinimalPerf.default 1211 1198 1.01:1
ListMinimalPerf.default 500 495 1.01:1
PortalMinimalPerf.default 175 173 1.01:1
ProviderMinimalPerf.default 915 904 1.01:1
SliderMinimalPerf.default 1521 1500 1.01:1
SplitButtonMinimalPerf.default 3615 3563 1.01:1
CustomToolbarPrototype.default 3655 3631 1.01:1
ToolbarMinimalPerf.default 901 890 1.01:1
AlertMinimalPerf.default 260 259 1:1
AnimationMinimalPerf.default 401 403 1:1
CheckboxMinimalPerf.default 2662 2671 1:1
DatepickerMinimalPerf.default 5246 5227 1:1
DropdownMinimalPerf.default 3014 3005 1:1
LoaderMinimalPerf.default 666 665 1:1
MenuMinimalPerf.default 809 813 1:1
TextAreaMinimalPerf.default 482 480 1:1
FlexMinimalPerf.default 275 278 0.99:1
ListWith60ListItems.default 602 609 0.99:1
MenuButtonMinimalPerf.default 1512 1535 0.99:1
ProviderMergeThemesPerf.default 1597 1620 0.99:1
TextMinimalPerf.default 329 332 0.99:1
TooltipMinimalPerf.default 954 960 0.99:1
HeaderSlotsPerf.default 706 722 0.98:1
RosterPerf.default 1111 1128 0.98:1
TableMinimalPerf.default 376 384 0.98:1
CarouselMinimalPerf.default 442 458 0.97:1
ChatDuplicateMessagesPerf.default 276 286 0.97:1
StatusMinimalPerf.default 631 652 0.97:1
IconMinimalPerf.default 586 602 0.97:1
AccordionMinimalPerf.default 141 148 0.95:1
SegmentMinimalPerf.default 316 334 0.95:1

@bsunderhus bsunderhus closed this Jun 15, 2021
@bsunderhus bsunderhus reopened this Jun 15, 2021
@bsunderhus bsunderhus marked this pull request as ready for review June 15, 2021 09:18
@bsunderhus bsunderhus requested a review from a team as a code owner June 15, 2021 09:18
@ling1726
Copy link
Contributor

ling1726 commented Jun 15, 2021 •
edited
Loading

As @Hotell has mentioned before we should be adding at least a codeowner to each package. So it's easy to find some point of contact

@ling1726
Copy link
Contributor

ling1726 commented Jun 15, 2021

Can we scaffold the package in a separate PR with private: true ? so that it's easier to review the actual logic you want to introduce in the package

Hotell
Hotell reviewed Jun 15, 2021
View reviewed changes
Copy link
Contributor

@Hotell Hotell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • scaffolding and migration - LGTM
  • implementation - few questions/comments

NOTE: pls don't forgot to add proper codeowner for this package

thx!

ling1726
ling1726 reviewed Jun 15, 2021
View reviewed changes
ling1726
ling1726 reviewed Jun 15, 2021
View reviewed changes
ling1726
ling1726 reviewed Jun 15, 2021
View reviewed changes
ling1726
ling1726 reviewed Jun 15, 2021
View reviewed changes
ling1726
ling1726 reviewed Jun 15, 2021
View reviewed changes
ling1726
ling1726 reviewed Jun 15, 2021
View reviewed changes
@bsunderhus bsunderhus requested review from Hotell and ling1726 June 15, 2021 13:37
ling1726
ling1726 reviewed Jun 16, 2021
View reviewed changes
ling1726
ling1726 reviewed Jun 16, 2021
View reviewed changes
ling1726
ling1726 reviewed Jun 16, 2021
View reviewed changes
ling1726
ling1726 reviewed Jun 16, 2021
View reviewed changes
@bsunderhus bsunderhus enabled auto-merge (squash) June 16, 2021 09:18
@bsunderhus bsunderhus merged commit 4cba251 into microsoft:master Jun 16, 2021
@Hotell Hotell mentioned this pull request Jun 16, 2021
Closed
32 tasks
@bsunderhus bsunderhus deleted the react-aria branch June 16, 2021 10:36
@msft-fluent-ui-bot
Copy link
Collaborator

msft-fluent-ui-bot commented Jun 17, 2021

🎉@fluentui/react-aria@v9.0.0-alpha.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner

@JustSlone JustSlone Awaiting requested review from JustSlone JustSlone is a code owner

@Hotell Hotell Awaiting requested review from Hotell

1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bsunderhus bsunderhus

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bsunderhus @fabricteam @ling1726 @msft-fluent-ui-bot @Hotell @miroslavstastny