chore(Portal): Migrate to new DX by ling1726 · Pull Request #18482 · microsoft/fluentui

ling1726 · 2021-06-08T13:58:49Z

used nx workspace-generator migrate-converged-pkg to migrate
react-portal to the new DX

Pull request checklist

Addresses an existing issue: Fixes #0000
Include a change request file using $ yarn change

Description of changes

(give an overview)

Focus areas to test

(optional)

used `nx workspace-generator migrate-converged-pkg` to migrate `react-portal` to the new DX

size-auditor · 2021-06-08T14:14:03Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4cba25179eeb86d5a6cc38b13054e2627660d27f (build)

fabricteam · 2021-06-08T14:27:31Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	838	825	5000
BaseButton	mount	966	972	5000
Breadcrumb	mount	2576	2653	1000
ButtonNext	mount	549	550	5000
Checkbox	mount	1668	1609	5000
CheckboxBase	mount	1431	1417	5000
ChoiceGroup	mount	5040	5232	5000
ComboBox	mount	1015	990	1000
CommandBar	mount	10357	10216	1000
ContextualMenu	mount	6245	6296	1000
DefaultButton	mount	1213	1200	5000
DetailsRow	mount	4006	3893	5000
DetailsRowFast	mount	3954	3904	5000
DetailsRowNoStyles	mount	3733	3795	5000
Dialog	mount	2239	2251	1000
DocumentCardTitle	mount	147	145	1000
Dropdown	mount	3594	3512	5000
FocusTrapZone	mount	1822	1922	5000
FocusZone	mount	1807	1808	5000
IconButton	mount	1893	1877	5000
Label	mount	365	366	5000
Layer	mount	1929	1932	5000
Link	mount	479	496	5000
MakeStyles	mount	1833	1822	50000
MenuButton	mount	1544	1549	5000
MessageBar	mount	2032	1999	5000
Nav	mount	3453	3495	1000
OverflowSet	mount	1064	1084	5000
Panel	mount	2237	2124	1000
Persona	mount	909	914	1000
Pivot	mount	1522	1514	1000
PrimaryButton	mount	1352	1410	5000
Rating	mount	8187	8389	5000
SearchBox	mount	1446	1414	5000
Shimmer	mount	2935	2836	5000
Slider	mount	2104	2197	5000
SpinButton	mount	5285	5400	5000
Spinner	mount	424	427	5000
SplitButton	mount	3393	3365	5000
Stack	mount	533	542	5000
StackWithIntrinsicChildren	mount	1708	1678	5000
StackWithTextChildren	mount	5070	4953	5000
SwatchColorPicker	mount	10918	10696	5000
Tabs	mount	1521	1498	1000
TagPicker	mount	2541	2612	5000
TeachingBubble	mount	12286	12173	5000
Text	mount	441	454	5000
TextField	mount	1505	1474	5000
ThemeProvider	mount	1202	1261	5000
ThemeProvider	virtual-rerender	651	604	5000
ThemeProviderNext	mount	7006	6800	5000
Toggle	mount	846	843	5000
buttonNative	mount	136	115	5000

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ButtonMinimalPerf.default	200	182	1.1:1
FlexMinimalPerf.default	323	293	1.1:1
DropdownManyItemsPerf.default	771	718	1.07:1
MenuMinimalPerf.default	922	865	1.07:1
PopupMinimalPerf.default	606	572	1.06:1
ProviderMinimalPerf.default	1115	1054	1.06:1
GridMinimalPerf.default	369	351	1.05:1
LoaderMinimalPerf.default	756	721	1.05:1
SegmentMinimalPerf.default	389	372	1.05:1
SkeletonMinimalPerf.default	394	375	1.05:1
LabelMinimalPerf.default	434	418	1.04:1
ListMinimalPerf.default	570	547	1.04:1
ProviderMergeThemesPerf.default	1720	1660	1.04:1
TooltipMinimalPerf.default	1080	1036	1.04:1
AttachmentSlotsPerf.default	1230	1196	1.03:1
ButtonSlotsPerf.default	622	602	1.03:1
ChatMinimalPerf.default	713	693	1.03:1
DividerMinimalPerf.default	392	382	1.03:1
ImageMinimalPerf.default	411	400	1.03:1
RadioGroupMinimalPerf.default	483	468	1.03:1
TableManyItemsPerf.default	2144	2073	1.03:1
AnimationMinimalPerf.default	453	445	1.02:1
BoxMinimalPerf.default	376	369	1.02:1
DatepickerMinimalPerf.default	5784	5692	1.02:1
HeaderSlotsPerf.default	846	826	1.02:1
ListWith60ListItems.default	709	698	1.02:1
RefMinimalPerf.default	237	233	1.02:1
SliderMinimalPerf.default	1633	1600	1.02:1
TableMinimalPerf.default	431	424	1.02:1
TextMinimalPerf.default	381	375	1.02:1
ToolbarMinimalPerf.default	1083	1063	1.02:1
AccordionMinimalPerf.default	169	167	1.01:1
AlertMinimalPerf.default	286	282	1.01:1
CardMinimalPerf.default	636	630	1.01:1
CarouselMinimalPerf.default	501	496	1.01:1
DropdownMinimalPerf.default	3154	3126	1.01:1
ListCommonPerf.default	699	689	1.01:1
MenuButtonMinimalPerf.default	1693	1678	1.01:1
PortalMinimalPerf.default	180	179	1.01:1
TextAreaMinimalPerf.default	576	572	1.01:1
DialogMinimalPerf.default	816	813	1:1
EmbedMinimalPerf.default	4335	4314	1:1
HeaderMinimalPerf.default	382	383	1:1
ItemLayoutMinimalPerf.default	1373	1379	1:1
ListNestedPerf.default	596	597	1:1
ReactionMinimalPerf.default	415	413	1:1
SplitButtonMinimalPerf.default	4014	4034	1:1
TreeMinimalPerf.default	871	873	1:1
ButtonOverridesMissPerf.default	1760	1779	0.99:1
CheckboxMinimalPerf.default	2875	2913	0.99:1
FormMinimalPerf.default	440	445	0.99:1
InputMinimalPerf.default	1294	1310	0.99:1
LayoutMinimalPerf.default	400	405	0.99:1
AttachmentMinimalPerf.default	165	169	0.98:1
StatusMinimalPerf.default	739	753	0.98:1
IconMinimalPerf.default	686	701	0.98:1
CustomToolbarPrototype.default	3922	4000	0.98:1
TreeWith60ListItems.default	190	193	0.98:1
VideoMinimalPerf.default	672	691	0.97:1
ChatDuplicateMessagesPerf.default	316	329	0.96:1
ChatWithPopoverPerf.default	379	396	0.96:1
RosterPerf.default	1255	1308	0.96:1
AvatarMinimalPerf.default	206	216	0.95:1

Hotell

Please rebase from master and run the migration again, we added 2 more modifications for nx workspace in general. thx!

ling1726 · 2021-06-15T09:26:55Z

@Hotell you mind taking another look at this ?

Hotell · 2021-06-15T10:20:00Z

packages/react-examples/package.json

hmm is this a bug in the migration ? both of these should have been removed by migration

oh outdated ? I guess I checked the PR while you've been rebasing ? :D

Hotell

action required: pls make sure to remove portal from react-examples package.json

msft-fluent-ui-bot · 2021-06-17T07:36:41Z

🎉@fluentui/react-popover@v9.0.0-alpha.9 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-06-17T07:36:44Z

🎉@fluentui/react-menu@v9.0.0-alpha.38 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-06-17T07:36:47Z

🎉@fluentui/react-examples@v8.29.0 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-06-17T07:36:50Z

🎉@fluentui/react-tooltip@v9.0.0-alpha.46 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-06-17T07:36:56Z

🎉@fluentui/react-components@v9.0.0-alpha.66 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-06-17T07:36:59Z

🎉@fluentui/public-docsite@v8.2.28 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-06-17T07:37:10Z

🎉@fluentui/public-docsite-resources@v8.1.28 has been released which incorporates this pull request.:tada:

Handy links:

chore(Portal): Migrate to new DX

081a27d

used `nx workspace-generator migrate-converged-pkg` to migrate `react-portal` to the new DX

msft-fluent-ui-bot assigned miroslavstastny Jun 8, 2021

ling1726 added 3 commits June 8, 2021 16:00

Change files

6246b26

update change file

58bc886

run prettier

64b0210

ling1726 marked this pull request as ready for review June 9, 2021 10:07

ling1726 requested a review from a team as a code owner June 9, 2021 10:07

Hotell reviewed Jun 9, 2021

View reviewed changes

ling1726 added 3 commits June 14, 2021 21:03

conflicts

85b9f51

run migration again

03e521e

merge master

81bd9ed

ling1726 requested a review from a team as a code owner June 14, 2021 19:08

ling1726 requested a review from Hotell June 14, 2021 19:08

ling1726 added 2 commits June 14, 2021 21:09

solve conflicts

cbd0626

revert react-file

8faf72e

ling1726 removed the request for review from a team June 14, 2021 19:13

Hotell reviewed Jun 15, 2021

View reviewed changes

Hotell approved these changes Jun 15, 2021

View reviewed changes

Hotell mentioned this pull request Jun 16, 2021

migration: migrate converged packages to new DX (1st stage) #18579

Closed

32 tasks

ling1726 added 2 commits June 16, 2021 12:40

remove portal from examples

03ad580

merge conflicts

139db33

ling1726 enabled auto-merge (squash) June 16, 2021 10:59

ling1726 merged commit fc966e8 into microsoft:master Jun 16, 2021

Conversation

ling1726 commented Jun 8, 2021

Pull request checklist

Description of changes

Focus areas to test

Uh oh!

size-auditor bot commented Jun 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Jun 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Perf Analysis (@fluentui/react-northstar)

Uh oh!

Hotell left a comment

Choose a reason for hiding this comment

Uh oh!

ling1726 commented Jun 15, 2021

Uh oh!

Hotell Jun 15, 2021

Choose a reason for hiding this comment

Uh oh!

Hotell Jun 15, 2021

Choose a reason for hiding this comment

Uh oh!

Hotell left a comment

Choose a reason for hiding this comment

Uh oh!

msft-fluent-ui-bot commented Jun 17, 2021

Uh oh!

msft-fluent-ui-bot commented Jun 17, 2021

Uh oh!

msft-fluent-ui-bot commented Jun 17, 2021

Uh oh!

msft-fluent-ui-bot commented Jun 17, 2021

Uh oh!

msft-fluent-ui-bot commented Jun 17, 2021

Uh oh!

msft-fluent-ui-bot commented Jun 17, 2021

Uh oh!

msft-fluent-ui-bot commented Jun 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

size-auditor bot commented Jun 8, 2021 •

edited

Loading

fabricteam commented Jun 8, 2021 •

edited

Loading

Perf Analysis (`@fluentui/react`)

Perf Analysis (`@fluentui/react-northstar`)