Skip to content

POC: rewrite jest-serializer-make-styles to JS#18356

Closed
layershifter wants to merge 1 commit intomasterfrom
chore/mk-serializer-js
Closed

POC: rewrite jest-serializer-make-styles to JS#18356
layershifter wants to merge 1 commit intomasterfrom
chore/mk-serializer-js

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented May 27, 2021 •
edited
Loading

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

 PASS  src/components/Image/Image.test.tsx (8.415s)
[12:04:52 PM] ■ finished 'jest' in 11.78s
[12:04:52 PM] ■ finished 'test' in 11.78s

@layershifter layershifter mentioned this pull request May 27, 2021
Closed
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 27, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 999a5ce:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@miroslavstastny
Copy link
Member

miroslavstastny commented May 31, 2021

The only use case for the serializer was Flex which has been removed. Do we want to keep the serializer?

@layershifter
Copy link
Member Author

layershifter commented May 31, 2021

The only use case for the serializer was Flex which has been removed. Do we want to keep the serializer?

This could be added as an item for discussion 😊

@layershifter layershifter deleted the chore/mk-serializer-js branch June 1, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@layershifter @miroslavstastny