Website: fix related link underlines#16721
Merged
ecraig12345 merged 1 commit intomicrosoft:masterfrom Feb 3, 2021
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 31ba28c:
|
50403cb to
81f3b0a
Compare
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 37523ddb09fe0156f7081d214457eeff566e0b19 (build) |
Collaborator
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
81f3b0a to
31ba28c
Compare
khmakoto
approved these changes
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Follow-up to #16625 (adding underlined Links): there were problems with getting the links in the Related sidebar of the website to not be underlined, since they're rendered with the Markdown component which underlines its links by default.
The workaround is to move the lists of component related links from markdown files (containing bulleted lists) to arrays of
ISideRailLink. I think this is a better approach anyway because it gets rid of an excess boilerplate file which only ever contained identically-formatted lists of items and required an obnoxious raw-loader import.While testing this, I discovered that dzearing's webpack 5 change broke testing the website locally due to (for some reason) now serving it at(fixed elsewhere)http://[::]:4322/instead oflocalhost, and certain places were checking specifically forlocalhost.