Skip to content

[Bug]: ToastTitle link regression, wrong color is used #35341

@Zlatkovsky

Description

@Zlatkovsky

Component

Toast

Package version

9.68.4

React version

18.3.1

Environment

System:
    OS: Windows 11 10.0.26200
    CPU: (12) x64 12th Gen Intel(R) Core(TM) i7-1265U
    Memory: 9.75 GB / 31.83 GB
  Browsers:
    Chrome: 141.0.7390.77
    Edge: Chromium (141.0.3537.71)
    Internet Explorer: 11.0.26100.1882

Current Behavior

In fluentui/react-components@9.67.0 and earlier (e.g., 9.66.6), a link on ToastTitle -- where the Toast's appearance was "inverted" -- was showing up as colored:

<Toast appearance="inverted">
    <ToastTitle action={<Link>{'This is a link'}</Link>}></ToastTitle>
</Toast>
Image

In newer versions (e.g., 9.68.0, and up through today's latest of 9.72.2), this behavior regressed to it showing in white only:

Image

Expected Behavior

Expecting no behavioral change, given that it's all a single major version.

Comparing the code differences between 9.67.0 and 9.68.4 -- https://github.com/microsoft/fluentui/compare/%40fluentui/react-components_v9.67.0..%40fluentui/react-components_v9.68.4 -- I have a strong suspicion that this is related:

Image

Reproduction

https://stackblitz.com/edit/anz1mbci-egquqch5 versus https://stackblitz.com/edit/anz1mbci-mr5taacy

Steps to reproduce

Baseline version (9.66.6): https://stackblitz.com/edit/anz1mbci-egquqch5?file=package.json

Broken version (9.68.4): https://stackblitz.com/edit/anz1mbci-mr5taacy?file=package.json

In both cases, I used resolutions to ensure that I was picking up just the desired version and its sub-dependencies, rather than letting yarn skip ahead to the latest

Are you reporting an Accessibility issue?

no

Suggested severity

Medium - Has workaround

Products/sites affected

This is preventing our team from bumping to latest FluentUI (though we may be able to patch-package)

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions