-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closed
Description
Library
React Components / v9 (@fluentui/react-components)
System Info
N/AAre you reporting Accessibility issue?
None
Reproduction
N/A
Bug Description
Actual Behavior
Listeners are not passive:
fluentui/packages/react-components/react-positioning/src/createPositionManager.ts
Lines 133 to 134 in d1a32c7
| targetWindow.addEventListener('scroll', updatePosition); | |
| targetWindow.addEventListener('resize', updatePosition); |
Expected Behavior
Listeners should be passive for better performance:
https://developer.chrome.com/docs/lighthouse/best-practices/uses-passive-event-listeners/
Logs
N/ARequested priority
High
Products/sites affected
N/A
Are you willing to submit a PR to fix?
yes
Validations
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- The provided reproduction is a minimal reproducible example of the bug.
Reactions are currently unavailable