-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closed
Description
@fluentui/react-search-preview package should migrate to the new slot API methods (slot and assertSlot), but there are some problems in the component render method that got in the way of the automation codemod that did the upgrade.
It seems like logic from state hook is leaking to render method, using the new API makes it impossible to inject logic via overrides on the render method.
fluentui/packages/react-components/react-search-preview/src/components/SearchBox/renderSearchBox.tsx
Lines 17 to 27 in 4eec212
| const rootSlots = { | |
| contentAfter: slots.contentAfter && { | |
| ...slotProps.contentAfter, | |
| children: ( | |
| <> | |
| {slotProps.contentAfter.children} | |
| {slots.dismiss && <slots.dismiss {...slotProps.dismiss} />} | |
| </> | |
| ), | |
| }, | |
| }; |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels