-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closed
Labels
Area: TypescriptFluent UI react (v8)Issues about @fluentui/react (v8)Issues about @fluentui/react (v8)Priority 1: HighReact 17Status: FixedFixed in some PRFixed in some PR
Description
Library
React / v8 (@fluentui/react)
System Info
naAre you reporting Accessibility issue?
None
Reproduction
yarn lage build --to @fluentui/ts-minbar-test-reactyarn workspace @fluentui/ts-minbar-test-react test
Bug Description
Actual Behavior
Observed yesterday (3rd of April in master pipeline ).
our TS minbar is a safeguard to prevent shipping non supported TS features to our users.
for react(v8) test suite we specify dependencies like for react types via @types/react@17, which during test run will install latest 17 type version.
- version 17.0.55 worked as expected
- version 17.0.56 introduced breaking change making
tscthrow error
👀 Issue introduce by this PR DefinitelyTyped/DefinitelyTyped@3f5d206#diff-6df5e9a2eb9edb2dcf93fe75b95032e8870a94789157856c5544ece346026a0a
Diff:
version 17.0.56 did some content interface property re-shuffling which causes following tsc errors:
Expected Behavior
minor/patch versions of 3rd party types should not introduce breaking changes - this needs to be fixed on DefinitelyTyped repo.
Logs
No response
Requested priority
Blocking
Products/sites affected
No response
Are you willing to submit a PR to fix?
no
Validations
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- The provided reproduction is a minimal reproducible example of the bug.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area: TypescriptFluent UI react (v8)Issues about @fluentui/react (v8)Issues about @fluentui/react (v8)Priority 1: HighReact 17Status: FixedFixed in some PRFixed in some PR



