Skip to content

[Bug]: eslint is not invoked on pre-commit hook #25532

@Hotell

Description

@Hotell

Library

whole monorepo is affected

System Info

NA

Are you reporting Accessibility issue?

no

Reproduction

  1. add console.log('foo') to any isConformant.ts file
  2. stage that file git add
  3. yarn lint-staged --debug
  4. yarn workspace @flunetui/<your-package> lint to verify there is lint error

Bug Description

Actual Behavior

We invoke eslint within lint staged by calling this script 'node ./scripts/lint-staged/eslint'.

Turns out that doesn't work.

In last PR a lint error slipped through this check and I got error on CI:
image

lint-staged execution:

image

Expected Behavior

eslint should work on pre-commit

Logs

No response

Requested priority

High

Products/sites affected

No response

Are you willing to submit a PR to fix?

yes

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions