Skip to content

[Bug]: PeoplePicker onRenderNoResultsFound infinite loop  #24128

@SudharsanSukumar

Description

@SudharsanSukumar

Library

React / v8 (@fluentui/react)

System Info

System:
    OS: Windows 10 10.0.22000
    CPU: (24) x64 AMD Ryzen 9 3900X 12-Core Processor
    Memory: 33.50 GB / 63.92 GB
  Browsers:
    Chrome: 103.0.5060.114
    Edge: Spartan (44.22000.120.0), Chromium (103.0.1264.49)
    Internet Explorer: 11.0.22000.120

Are you reporting Accessibility issue?

no

Reproduction

onRenderNoResultFound(undefined, noResults)

Bug Description

Actual Behavior

Infinite loop when there are no results. Flow is

Render -> no results -> if prop is specified, call it and pass no results callback as the default renderer. If consumer uses the default renderer it will cause a loop.

Our logic:
image

Expected Behavior

Calling the default renderer shouldn't be self referencing. See

onRenderNoResultFound(undefined, noResults)

Logs

No response

Requested priority

High

Products/sites affected

Microsoft Planner

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions