-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Open
Labels
Area: Build SystemResolution: Soft CloseSoft closing inactive issues over a certain periodSoft closing inactive issues over a certain periodType: Epic
Description
Story 🧚♀️
Actual behavior:
Currently every packages includes exact same list of devDependencies/
"devDependencies": {
"@fluentui/babel-make-styles": "9.0.0-beta.4",
"@fluentui/eslint-plugin": "*",
"@fluentui/jest-serializer-make-styles": "9.0.0-beta.4",
"@fluentui/react-conformance": "*",
"@fluentui/react-conformance-make-styles": "9.0.0-beta.4",
"@fluentui/scripts": "^1.0.0",
"@types/enzyme": "3.10.3",
"@types/enzyme-adapter-react-16": "1.0.3",
"@types/react-test-renderer": "^16.3.0",
"@types/react": "16.9.42",
"@types/react-dom": "16.9.10",
"enzyme": "~3.10.0",
"enzyme-adapter-react-16": "^1.15.0",
"react": "16.8.6",
"react-dom": "16.8.6",
"react-test-renderer": "^16.3.0"
},Expected behavior:
All devDependencies should adhere to "single version policy in monorepo". Why ?
- every devDependency is defined in root
package.json- TBD: use pinned version to align with yarn.lock ( this might be detrimental in terms of modules de-dupe though)
- if package really needs to opt out, it will specify different version of devDependency within its package.json to prevent hoisting. (this should be only last resort and for temporary time period )
Tasks
- write migration feat(tools): implement single version policy generator #26437
- migrate to lastest syncpack
- update existing plol generator
- execute migration in batch
- add lint checks to prevent violations
Related issues
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area: Build SystemResolution: Soft CloseSoft closing inactive issues over a certain periodSoft closing inactive issues over a certain periodType: Epic