Skip to content

feat: adopt single version policy for monorepo dependencies #21395

@Hotell

Description

@Hotell

Story 🧚‍♀️

Actual behavior:

Currently every packages includes exact same list of devDependencies/

"devDependencies": {
    "@fluentui/babel-make-styles": "9.0.0-beta.4",
    "@fluentui/eslint-plugin": "*",
    "@fluentui/jest-serializer-make-styles": "9.0.0-beta.4",
    "@fluentui/react-conformance": "*",
    "@fluentui/react-conformance-make-styles": "9.0.0-beta.4",
    "@fluentui/scripts": "^1.0.0",
    "@types/enzyme": "3.10.3",
    "@types/enzyme-adapter-react-16": "1.0.3",
     "@types/react-test-renderer": "^16.3.0",
    "@types/react": "16.9.42",
    "@types/react-dom": "16.9.10",
    "enzyme": "~3.10.0",
    "enzyme-adapter-react-16": "^1.15.0",
    "react": "16.8.6",
    "react-dom": "16.8.6",
    "react-test-renderer": "^16.3.0"
  },

Expected behavior:

All devDependencies should adhere to "single version policy in monorepo". Why ?

  • every devDependency is defined in root package.json
    • TBD: use pinned version to align with yarn.lock ( this might be detrimental in terms of modules de-dupe though)
  • if package really needs to opt out, it will specify different version of devDependency within its package.json to prevent hoisting. (this should be only last resort and for temporary time period )

Tasks

Related issues

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions