-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closed
Labels
Milestone
Description
As we are going to leverage Storybook (SB) for convergence (primarily the Composition feature) we need to migrate to SB v6.
Currently we are at
5.3
Tasks:
in general follow migration guide
- bump
@storybook/*deps in whole repo (NOTE: potential merge conflicts with chore: apply single version policy on storybook #16965 )
What apps/packages will be affected:
apps/vr-tests- contains storybooks that are executed against Screener for visual regressions- stories are using deprecated
storiesOfAPI (TBD if we gonna go migrate toCSF?) - no action needed for now - SB config uses "deprecated" API's (chore: apply single version policy on storybook #16965)
- screener doesn't support SB6 apis (Blocker) (chore: apply single version policy on storybook #16965)
- stories are using deprecated
packages/storybook- our custom package that provides various fluentui related SB extensions- there might be some API changes needed as well
packages/react-examplesuses deprecated config apis- preview.js uses imperative calls
configure(), addDecorator()etc - this will need to be manually migrated to
main.js. -
If that might turn out to be too difficult, we can opt out temporarily (
no-hoist ?, explicitly defining all SB deps to v 5.3 withinscripts/package). In long run we wanna use 1 version of "critical" tool that we use within monorepo.
- preview.js uses imperative calls
packages/fluentui: no action needed - SB is not being usedpackages/web-components- they are using SB 5.3. We need to opt out explicitly probably viano-hoistas we are not owners of this package and we don't wanna break their stuff (handled by this PR)
Reactions are currently unavailable