Update deployment support for Azure China#314
Merged
Conversation
flanakin
requested changes
Sep 5, 2023
flanakin
left a comment
Collaborator
There was a problem hiding this comment.
@yuanzhang9 This change looks good. Can you also add the bicep changes needed to support China?
|
@yuanzhang9: you have some new feedback! Please review and resolve all comments and I'll let reviewers know by removing the |
Contributor
Author
|
Update to support China region for both Bicep and ARM |
Contributor
Author
|
@flanakin new commits to the same PR are Bicep files as well as the read me file. |
flanakin
approved these changes
Oct 29, 2023
flanakin
approved these changes
Oct 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Add support for Azure China in Finops hubs.
Fixes #259
🔬 How has this been tested?