fix: Deploy-FinOpsHub fails in Cloud Shell/Linux (#665)#1975
Merged
Conversation
9eaa4ee to
1d75a84
Compare
Two issues were causing Deploy-FinOpsHub to fail in Cloud Shell/Linux: 1. Bicep CLI requires the TEMP environment variable, which is not set on Linux/Mac. Added code to set TEMP from [System.IO.Path]::GetTempPath() if not present. 2. If an error occurred before $toolkitPath was set, the finally block cleanup failed with 'Cannot bind argument to parameter Path because it is null', masking the real error. Initialized $toolkitPath before the try block and added a null check before cleanup. Fixes #665
flanakin
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Initialize
$toolkitPathbefore the try block to ensure cleanup works even if an early failure occurs. The$toolkitPathvariable was being set inside the try block, but the finally block attempted to use it for cleanup. If an error occurred before$toolkitPathwas set (e.g., when$env:tempis not defined on Linux/Cloud Shell), the cleanup failed with "Cannot bind argument to parameter 'Path' because it is null", masking the real error.Fixes #665
📷 Screenshots
N/A - Code fix only
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?