Fix Start-FinOpsCostExport unit tests#1646
Merged
Merged
Conversation
added 2 commits
May 30, 2025 02:53
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Start-FinOpsCostExport unit tests to use a consistent backfill date range, ensures UTC date normalization in the command, and refines the verbose log output.
- Test changes: updated StartDate/EndDate in tests, added UTC date setup, and assertions for backfill Invoke-Rest calls
- Command changes: normalized default StartDate to UTC midnight and enhanced the Write-Verbose message to include full ISO timestamps
- Changelog updated with the new PowerShell module version entry
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/powershell/Tests/Unit/Start-FinOpsCostExport.Tests.ps1 | Adjusted test date ranges, added $today and $startOfMonth in UTC, and backfill call assertions |
| src/powershell/Public/Start-FinOpsCostExport.ps1 | Changed default StartDate normalization to .ToUniversalTime().Date and updated verbose logging format |
| docs-mslearn/toolkit/changelog.md | Added PowerShell module v0.10 entry with Start-FinOpsCostExport fix |
RolandKrummenacher
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Fix Start-FinOpsCostExport unit test and bug where the initial export fails during the backfill process
Fixes #988, #884
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?