Skip to content

[AOE] Fix for right-size recommendations issue when current SKU UncachedDiskBytesPerSecond is greater than Int.MaxValue#1531

Merged
helderpinto merged 2 commits into
microsoft:devfrom
helderpinto:helderpinto/dev/aoe-fix1526
Apr 25, 2025
Merged

[AOE] Fix for right-size recommendations issue when current SKU UncachedDiskBytesPerSecond is greater than Int.MaxValue#1531
helderpinto merged 2 commits into
microsoft:devfrom
helderpinto:helderpinto/dev/aoe-fix1526

Conversation

@helderpinto

Copy link
Copy Markdown
Member

🛠️ Description

Fix for right-size recommendations issue in Recommend-AdvisorCostAugmentedToBlobStorage runbook when current SKU UncachedDiskBytesPerSecond is greater than Int.MaxValue

Fixes #1526

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@helderpinto helderpinto added Micro PR 🔬 Very small PR that should be especially easy for newcomers Tool: Optimization Engine Azure Optimization Engine labels Apr 23, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Review 👀 PR that is ready to be reviewed label Apr 23, 2025
@flanakin flanakin added this to the 2025-04 - April milestone Apr 25, 2025
@flanakin flanakin added Status: ▶️ Ready Issue is ready for a dev to start work and removed Needs: Review 👀 PR that is ready to be reviewed labels Apr 25, 2025
@helderpinto helderpinto merged commit 2629614 into microsoft:dev Apr 25, 2025
@helderpinto helderpinto deleted the helderpinto/dev/aoe-fix1526 branch April 25, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Micro PR 🔬 Very small PR that should be especially easy for newcomers Status: ▶️ Ready Issue is ready for a dev to start work Tool: Optimization Engine Azure Optimization Engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AOE] Right-size recommendations break when current SKU UncachedDiskBytesPerSecond is greater than Int.MaxValue

3 participants