Skip to content

[AOE] Reservations Usage workbook uses the most recent reservation display name#1520

Merged
helderpinto merged 5 commits into
microsoft:devfrom
helderpinto:helderpinto/dev/aoe-fix1455
Apr 21, 2025
Merged

[AOE] Reservations Usage workbook uses the most recent reservation display name#1520
helderpinto merged 5 commits into
microsoft:devfrom
helderpinto:helderpinto/dev/aoe-fix1455

Conversation

@helderpinto

Copy link
Copy Markdown
Member

🛠️ Description

The Reservations Usage workbook has a Reservation filter that is preloaded with the list of all the active reservations. This fix ensure the latest reservation display name is used (in case the reservation display name changed over the course of the lookback period.

Fixes #1455

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@helderpinto helderpinto added Micro PR 🔬 Very small PR that should be especially easy for newcomers Tool: Optimization Engine Azure Optimization Engine labels Apr 18, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Review 👀 PR that is ready to be reviewed label Apr 18, 2025
@helderpinto helderpinto merged commit 2d198d4 into microsoft:dev Apr 21, 2025
@helderpinto helderpinto deleted the helderpinto/dev/aoe-fix1455 branch April 21, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed Tool: Optimization Engine Azure Optimization Engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AOE] Reservations Usage workbook is not using the most recent reservation display name

3 participants