[AOE] Fixes long-time deallocated VMs remediation runbook skipping eligible VMs#1510
Merged
helderpinto merged 10 commits intoApr 12, 2025
Merged
Conversation
flanakin
approved these changes
Apr 12, 2025
flanakin
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I'm not concerned about these suggestions. Feel free to take them or leave them.
Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Fixed issue with
Remediate-LongDeallocatedVMsFilteredrunbook that was skipping the remediation of eligible VMs due toAz.Computemodule breaking changes.Along the way, improved disk SKU management in
Remediate-UnattachedDisksFilteredrunbook with logic similar toRemediate-LongDeallocatedVMsFiltered.Fixes #1456
📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?