Skip to content

[AOE] Fix issues with tag duplicates (case sensitive) after tag inheritance#1431

Merged
arthurclares merged 2 commits into
microsoft:devfrom
helderpinto:helderpinto/dev/aoe-taginherit-bugfix
Mar 28, 2025
Merged

[AOE] Fix issues with tag duplicates (case sensitive) after tag inheritance#1431
arthurclares merged 2 commits into
microsoft:devfrom
helderpinto:helderpinto/dev/aoe-taginherit-bugfix

Conversation

@helderpinto

Copy link
Copy Markdown
Member

🛠️ Description

The Recommend-StorageAccountOptimizationsToBlobStorage runbook breaks when tag inheritance is enabled and billed resources inherit tags from resource groups and/or subscriptions that (case sensitive) duplicate resource tags.

Problem is solved by removing tag duplicates in the Log Analytics query, before parsing tags in PowerShell.

Fixes #1430

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin added Status: ▶️ Ready Issue is ready for a dev to start work and removed Needs: Review 👀 PR that is ready to be reviewed labels Mar 26, 2025
@arthurclares arthurclares merged commit c7f1f2f into microsoft:dev Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: ▶️ Ready Issue is ready for a dev to start work Tool: Optimization Engine Azure Optimization Engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AOE] Cost management tag inheritance with different tag casing breaks storage account recommendations

3 participants