Skip to content

Improvements to Rate Optimization report#1414

Merged
arthurclares merged 9 commits into
devfrom
arclares-rateoptimizationimprovements
Apr 2, 2025
Merged

Improvements to Rate Optimization report#1414
arthurclares merged 9 commits into
devfrom
arclares-rateoptimizationimprovements

Conversation

@arthurclares

@arthurclares arthurclares commented Mar 19, 2025

Copy link
Copy Markdown
Collaborator

…commendations. #1408, [HUB] Reservation Recommendations not populating correctly in Rate Optimization Power BI (ADX 0.8) #1388, [Power B] Add RI/SP breakeven point to Rate optimization report #406

🛠️ Description

This PR implement changes to the Rate Optimization Report. It has three main changes:
1- Change how reservations are summarized to ensure the latest version of each recommendation is displayed.
2- Implement a new break even point to the Rate Optimization (KQL and Storage)
3-Fix bug with reservation recommendation dates being wrong

Fixes #1408 #1388 #406

📷 Screenshots

image

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@arthurclares
Fixes [ADX] Reservations Recommendations doesn't surface all valid re…
7c9839f 
…commendations. #1408, [HUB] Reservation Recommendations not populating correctly in Rate Optimization Power BI (ADX 0.8) #1388, [Power B] Add RI/SP breakeven point to Rate optimization report #406
@arthurclares
Update changelog
8654e94
@arthurclares arthurclares requested a review from MSBrett as a code owner March 19, 2025 16:08
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Review 👀 PR that is ready to be reviewed label Mar 19, 2025
ro100e
ro100e previously approved these changes Mar 28, 2025
View reviewed changes

@ro100e ro100e left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes in RateOptimization Report, and verified the fix did populate data. However, when testing in another environment, received what looks like a discrepancy in the Core hours by region visual.

flanakin
flanakin requested changes Mar 28, 2025
View reviewed changes
Comment thread docs-mslearn/toolkit/changelog.md Outdated
Comment thread docs-mslearn/toolkit/changelog.md Outdated
Comment thread src/power-bi/kql/Shared.Dataset/definition/tables/ReservationRecommendations.tmdl Outdated
Comment thread src/power-bi/kql/Shared.Dataset/definition/tables/ReservationRecommendations.tmdl Outdated
Comment thread src/power-bi/kql/Shared.Dataset/definition/tables/ReservationRecommendations.tmdl
Comment thread src/power-bi/storage/Shared.Dataset/definition/tables/ReservationRecommendations.tmdl Outdated
Comment thread src/templates/finops-hub/modules/scripts/IngestionSetup.kql Outdated
Comment thread src/templates/finops-hub/modules/scripts/IngestionSetup.kql Outdated
Comment thread src/templates/finops-hub/modules/scripts/IngestionSetup.kql Outdated
@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity and removed Needs: Review 👀 PR that is ready to be reviewed labels Mar 28, 2025
@flanakin flanakin added this to the 2025-03 - March milestone Mar 28, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs: Review 👀 PR that is ready to be reviewed and removed Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity labels Mar 28, 2025
@ro100e ro100e self-requested a review March 29, 2025 00:37
@flanakin flanakin added Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity and removed Needs: Review 👀 PR that is ready to be reviewed labels Mar 29, 2025
This was linked to issues Mar 31, 2025
[Power B] Add RI/SP breakeven point to Rate optimization report #406
Closed
[HUB] Reservation Recommendations not populating correctly in Rate Optimization Power BI (ADX 0.8) #1388
Closed
@arthurclares @flanakin
Update src/power-bi/kql/Shared.Dataset/definition/tables/ReservationR…
7e866f0 
…ecommendations.tmdl

Co-authored-by: Michael Flanakin <flanakin@users.noreply.github.com>
@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs: Review 👀 PR that is ready to be reviewed and removed Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity labels Mar 31, 2025
flanakin
flanakin previously approved these changes Mar 31, 2025
View reviewed changes
@flanakin flanakin added the Tool: Power BI Power BI reports label Mar 31, 2025
@flanakin flanakin dismissed stale reviews from ro100e and themself via a9ffbb8 April 1, 2025 06:30
@ro100e ro100e removed their request for review April 1, 2025 13:19
@arthurclares arthurclares enabled auto-merge (squash) April 1, 2025 16:26
@arthurclares arthurclares merged commit bda6a54 into dev Apr 2, 2025
@arthurclares arthurclares deleted the arclares-rateoptimizationimprovements branch April 2, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ro100e ro100e ro100e left review comments
@MSBrett MSBrett Awaiting requested review from MSBrett MSBrett is a code owner
@flanakin flanakin Awaiting requested review from flanakin flanakin is a code owner

Assignees

@flanakin flanakin

@arthurclares arthurclares

Labels

Needs: Review 👀 PR that is ready to be reviewed Tool: Power BI Power BI reports

Projects

None yet

Milestone

2025-03 - March

3 participants

@arthurclares @flanakin @ro100e