Skip to content

Fix MCA reservation recommendation export ingestion#1402

Merged
flanakin merged 13 commits into
devfrom
flanakin/dev/hubs-mcarirecs
Mar 31, 2025
Merged

Fix MCA reservation recommendation export ingestion#1402
flanakin merged 13 commits into
devfrom
flanakin/dev/hubs-mcarirecs

Conversation

@flanakin

@flanakin flanakin commented Mar 14, 2025

Copy link
Copy Markdown
Collaborator

🛠️ Description

  • Add sample MCA reservation export files
  • Remove spaces from parquet column names
  • Added support for multiple reservation recommendation exports
  • Fixed an issue where reservation recommendations were being duplicated for the Canada Central region
  • Fixed an issue where Recommendations.x_IngestionTime is not being populated in Data Explorer
  • Changed a Central Canada reference to Canada Central in the Regions open data

Fixes #1317, #1322, #1323, #1324, #1325

Related to #1407

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin added the Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity label Mar 14, 2025
@flanakin flanakin added this to the 2025-03 - March milestone Mar 14, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added Tool: Open data Datasets to normalize and enhance FinOps reports Needs: Review 👀 PR that is ready to be reviewed labels Mar 14, 2025
@flanakin flanakin removed the Needs: Review 👀 PR that is ready to be reviewed label Mar 14, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs: Review 👀 PR that is ready to be reviewed and removed Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity labels Mar 20, 2025
@flanakin flanakin force-pushed the flanakin/dev/hubs-mcarirecs branch from 8ff19b4 to 3e4a0ef Compare March 22, 2025 22:32
@flanakin flanakin marked this pull request as ready for review March 24, 2025 04:01
@flanakin flanakin enabled auto-merge (squash) March 24, 2025 04:01
@flanakin flanakin added Tool: Power BI Power BI reports Tool: FinOps hubs Data pipeline solution labels Mar 24, 2025
@flanakin flanakin merged commit e7ef307 into dev Mar 31, 2025
@flanakin flanakin deleted the flanakin/dev/hubs-mcarirecs branch March 31, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution Tool: Open data Datasets to normalize and enhance FinOps reports Tool: Power BI Power BI reports

Projects

None yet

3 participants