Skip to content

Remove the MI Contributor role assignment for hubs deployments#1394

Merged
flanakin merged 3 commits into
devfrom
flanakin/dev/hubs-nomicontrib
Mar 14, 2025
Merged

Remove the MI Contributor role assignment for hubs deployments#1394
flanakin merged 3 commits into
devfrom
flanakin/dev/hubs-nomicontrib

Conversation

@flanakin

Copy link
Copy Markdown
Collaborator

🛠️ Description

  • Remove the MI Contributor role assignment for hubs deployments
  • Document the permissions that will be assigned during the deployment

Fixes #1248

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin enabled auto-merge (squash) March 13, 2025 06:43

@philipstreet philipstreet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@flanakin flanakin added the Tool: FinOps hubs Data pipeline solution label Mar 13, 2025
@flanakin

Copy link
Copy Markdown
Collaborator Author

@allcontributors please add @philipstreet for review

@allcontributors

Copy link
Copy Markdown
Contributor

@flanakin

I've put up a pull request to add @philipstreet! 🎉

@flanakin flanakin merged commit 1d5c03a into dev Mar 14, 2025
@flanakin flanakin deleted the flanakin/dev/hubs-nomicontrib branch March 14, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code: InvalidTemplateDeployment

3 participants