Skip to content

Fix scopes object array in settings.json#1379

Merged
flanakin merged 2 commits into
devfrom
flanakin/dev/hubs-scopesarray
Mar 10, 2025
Merged

Fix scopes object array in settings.json#1379
flanakin merged 2 commits into
devfrom
flanakin/dev/hubs-scopesarray

Conversation

@flanakin

@flanakin flanakin commented Mar 9, 2025

Copy link
Copy Markdown
Collaborator

🛠️ Description

Applied suggestion from @nsftwr to fix the scopes property in settings.json so it's always an array. Also cleaned up some other issues with the scopes array.

Fixes #1237

📷 Screenshots

Screenshot of the upload settings script output

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin added this to the 2025-03 - March milestone Mar 9, 2025
@flanakin flanakin requested a review from MSBrett as a code owner March 9, 2025 10:24
@microsoft-github-policy-service microsoft-github-policy-service Bot added Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed labels Mar 9, 2025
@flanakin flanakin added the Tool: FinOps hubs Data pipeline solution label Mar 10, 2025
@flanakin flanakin enabled auto-merge (squash) March 10, 2025 15:53
@flanakin flanakin merged commit 3ea7b0d into dev Mar 10, 2025
@flanakin flanakin deleted the flanakin/dev/hubs-scopesarray branch March 10, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid settings.json schema on FinOps Hub deployment

3 participants