Skip to content

Fix Total savings and AHB reports#1374

Merged
flanakin merged 6 commits into
devfrom
flanakin/dev/pbi-ro-ahbsavings
Mar 14, 2025
Merged

Fix Total savings and AHB reports#1374
flanakin merged 6 commits into
devfrom
flanakin/dev/pbi-ro-ahbsavings

Conversation

@flanakin

@flanakin flanakin commented Mar 8, 2025

Copy link
Copy Markdown
Collaborator

🛠️ Description

  • Fixed core count double-counting on the Hybrid Benefit page.
  • Fixed savings to include negotiated discounts on the Total savings page.
  • Fixed Storage URL reference on KQL reports

Fixes #730, #1344

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin added this to the 2025-03 - March milestone Mar 8, 2025
@flanakin flanakin enabled auto-merge (squash) March 8, 2025 10:26
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Review 👀 PR that is ready to be reviewed label Mar 8, 2025
@flanakin flanakin added the Tool: Power BI Power BI reports label Mar 8, 2025
@flanakin

Copy link
Copy Markdown
Collaborator Author

@allcontributors please add @japyjaap for bug

@allcontributors

Copy link
Copy Markdown
Contributor

@flanakin

I've put up a pull request to add @japyjaap! 🎉

@flanakin flanakin merged commit fd47cf8 into dev Mar 14, 2025
@flanakin flanakin deleted the flanakin/dev/pbi-ro-ahbsavings branch March 14, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Review 👀 PR that is ready to be reviewed Tool: Power BI Power BI reports

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with Governance and WorkloadOptimization KQL and Storage PowerBI Reports Azure Hybrid Use Benefit calculations seem off

2 participants