Skip to content

FIx the New-FinOpsCostExport #1259

Merged
flanakin merged 3 commits into
devfrom
fix-New-FInOpsCostExport
Jan 31, 2025
Merged

FIx the New-FinOpsCostExport #1259
flanakin merged 3 commits into
devfrom
fix-New-FInOpsCostExport

Conversation

@arthurclares

@arthurclares arthurclares commented Jan 22, 2025

Copy link
Copy Markdown
Collaborator

🛠️ Description

fix: Set granularity to Monthly for PriceSheet exports

  • Updated the New-FinOpsCostExport script to dynamically set the granularity property based on the dataset type.
  • All other datasets continue to use Daily granularity as before.

Fixes #1193

📷 Screenshots

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

Comment thread src/powershell/Public/New-FinOpsCostExport.ps1 Outdated
@flanakin flanakin merged commit 4c9b65c into dev Jan 31, 2025
@flanakin flanakin deleted the fix-New-FInOpsCostExport branch January 31, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed Tool: PowerShell PowerShell scripts and automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New-FinOpsCostExport for dataset 'PriceSheet' fails with message 'Invalid dataset granularity: 'Daily'. (BadRequest)'

7 participants