Skip to content

Fix AU time zones#1182

Merged
MSBrett merged 5 commits into
devfrom
msbrett/dev/autzfix
Dec 17, 2024
Merged

Fix AU time zones#1182
MSBrett merged 5 commits into
devfrom
msbrett/dev/autzfix

Conversation

@MSBrett

@MSBrett MSBrett commented Dec 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

🛠️ Description

Corrects invalid timezone mappings in the azuretimezones.bicep file.

Fixes #1085

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@MSBrett MSBrett added Type: Bug 🐛 Something isn't working Micro PR 🔬 Very small PR that should be especially easy for newcomers Status: 🔬 Code review Issue is currently in code review with open PRs Skill: Data factory Data Factory integration Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution Resolution: Automerge This pull request can be merged automatically labels Dec 4, 2024
@MSBrett MSBrett self-assigned this Dec 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot added Skill: Deployment Resource deployment automation via bicep or terraform labels Dec 4, 2024
@MSBrett MSBrett mentioned this pull request Dec 4, 2024
Closed
flanakin
flanakin approved these changes Dec 9, 2024
View reviewed changes
Comment thread src/templates/finops-hub/modules/azuretimezones.bicep
@flanakin flanakin added Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity and removed Needs: Review 👀 PR that is ready to be reviewed labels Dec 10, 2024
@flanakin flanakin added this to the 2024-12 - December milestone Dec 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot added Needs: Review 👀 PR that is ready to be reviewed and removed Needs: Attention 👋 Issue or PR needs to be reviewed by the author or it will be closed due to no activity labels Dec 17, 2024
@MSBrett MSBrett merged commit de2f008 into dev Dec 17, 2024
@MSBrett MSBrett deleted the msbrett/dev/autzfix branch December 17, 2024 19:02
@helderpinto helderpinto mentioned this pull request Dec 20, 2024
Merged
@MSBrett MSBrett mentioned this pull request Jan 6, 2025
Closed
@psilantropy psilantropy mentioned this pull request Feb 12, 2026
Open
@hpwest7 hpwest7 mentioned this pull request Apr 13, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arthurclares arthurclares Awaiting requested review from arthurclares
@flanakin flanakin Awaiting requested review from flanakin flanakin is a code owner

Assignees

@flanakin flanakin

@MSBrett MSBrett

@arthurclares arthurclares

Labels

Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed Resolution: Automerge This pull request can be merged automatically Skill: Data factory Data Factory integration Skill: Deployment Resource deployment automation via bicep or terraform Status: 🔬 Code review Issue is currently in code review with open PRs Tool: FinOps hubs Data pipeline solution Type: Bug 🐛 Something isn't working

Projects

None yet

Milestone

2025-02 - February

Development

Successfully merging this pull request may close these issues.

FinOps hub deployment error / AzDataFactory Trigger script failure - Invalid Time Zone

3 participants

@MSBrett @flanakin @arthurclares