Skip to content

Semantic model relationship updates in Workload Optimization PowerBI#1164

Merged
flanakin merged 2 commits into
devfrom
1154-duplicate-values-in-workload-optimization-powerbi
Nov 28, 2024
Merged

Semantic model relationship updates in Workload Optimization PowerBI#1164
flanakin merged 2 commits into
devfrom
1154-duplicate-values-in-workload-optimization-powerbi

Conversation

@nteyan

@nteyan nteyan commented Nov 28, 2024

Copy link
Copy Markdown
Contributor

🛠️ Description

The relationship in the Power BI semantic model for Workload Optimization has been updated to address a bug involving duplicate IDs in the “VirtualMachines” and “Disks” tables.

Fixes #1154

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@nteyan nteyan linked an issue Nov 28, 2024 that may be closed by this pull request
@microsoft-github-policy-service microsoft-github-policy-service Bot added Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed labels Nov 28, 2024
Comment thread src/power-bi/storage/Shared.Dataset/definition/tables/Prices.tmdl
Comment thread src/power-bi/storage/Shared.Dataset/definition/tables/Prices.tmdl
@flanakin flanakin merged commit 9bbbd04 into dev Nov 28, 2024
@flanakin flanakin deleted the 1154-duplicate-values-in-workload-optimization-powerbi branch November 28, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed Tool: Power BI Power BI reports

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate Values in Workload Optimization PowerBI

3 participants