Skip to content

[Optimization engine] Fixes missing columns in EA savings plans exports#1047

Merged
arthurclares merged 3 commits into
microsoft:devfrom
helderpinto:helderpinto/dev/fix1026
Oct 11, 2024
Merged

[Optimization engine] Fixes missing columns in EA savings plans exports#1047
arthurclares merged 3 commits into
microsoft:devfrom
helderpinto:helderpinto/dev/fix1026

Conversation

@helderpinto

Copy link
Copy Markdown
Member

🛠️ Description

Fixes missing columns in EA savings plans exports, due to differences in expiry date and purchase date property names and date format.

Fixes #1026

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Review 👀 PR that is ready to be reviewed label Oct 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Tool: Optimization Engine Azure Optimization Engine label Oct 6, 2024
@helderpinto helderpinto changed the title Helderpinto/dev/fix1026 [Optimization engine] Fixes missing columns in EA savings plans exports Oct 6, 2024
@flanakin flanakin added this to the 2024-10 - October milestone Oct 6, 2024
@flanakin flanakin added the Status: ▶️ Ready Issue is ready for a dev to start work label Oct 7, 2024
@flanakin flanakin removed the Needs: Review 👀 PR that is ready to be reviewed label Oct 7, 2024
@arthurclares arthurclares merged commit 7680d0c into microsoft:dev Oct 11, 2024
@helderpinto helderpinto deleted the helderpinto/dev/fix1026 branch October 24, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: ▶️ Ready Issue is ready for a dev to start work Tool: Optimization Engine Azure Optimization Engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AOE - Workbook | Savings Plans Usage - Errors in tabs

3 participants