This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Ensure TypeScript is installed before starting#289
Merged
andrewbranch merged 1 commit intomasterfrom May 6, 2020
Merged
Conversation
sandersn
approved these changes
May 6, 2020
| function listen(dirPath: string, tsLocal: string | undefined): void { | ||
| process.on("message", (message: {}) => { | ||
| function listen(dirPath: string, tsLocal: string | undefined, onlyTestTsNext: boolean): void { | ||
| // Don't await this here to ensure that messages sent during installation aren't dropped. |
Member
There was a problem hiding this comment.
I bet THAT was tough to figure out.
Member
Author
There was a problem hiding this comment.
I bet it was, but I wasn’t the one who figured it out—I adapted this comment from one in listen’s caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This part of the code doesn’t have test coverage, but I validated it locally with @definitelytyped/dtslint-runner by
npm linking it.Also avoids installing all TypeScript versions under
--listenmode when--onlyTestTsNextis passed.