This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Update checks.ts#240
Merged
sandersn merged 1 commit intomicrosoft:masterfrom Aug 6, 2019
cortopy:patch-1
Merged
Conversation
Not all type definitions use `React.createElement` as the jsx pragma. I bumped into this issue when updating `storybook__preact` types as per DefinitelyTyped/DefinitelyTyped#37275 By adding the compiler option `jsxFactory` other pragmas can be used in type definitions
16 tasks
Contributor
Author
|
Ci failing for issues in @types/node which are not related to this commit |
Member
|
Looks like I need to update the |
sandersn
approved these changes
Aug 6, 2019
Member
|
I published 0.9.1, which has this change and the updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all type definitions use
React.createElementas the jsx pragma. I bumped into this issue when updatingstorybook__preacttypes as per DefinitelyTyped/DefinitelyTyped#37275By adding the compiler option
jsxFactoryother pragmas can be used in type definitions