Conversation
MichaelSimons
left a comment
There was a problem hiding this comment.
I realize this is WIP 😸. Since I took a look I thought I would send you a few comments on a few things I noticed.
samples/README.DockerHub.md
Outdated
|
|
||
| The following tags are the latest stable versions of the most commonly used images. The complete set of tags is listed further down. | ||
|
|
||
| - [`4.7.1`](https://github.com/Microsoft/dotnet-framework-docker/blob/master/4.7.1-windowsservercore-1709/runtime/Dockerfile) |
There was a problem hiding this comment.
I assume we will want to push both the dotnetapp as well as the aspnetapp. Should the tags be dotnetapp-3.5 and dotnetapp-4.7.2 and mirrored for aspnetapp?
| Type the following command to run a sample console application: | ||
|
|
||
| ```console | ||
| docker run --rm microsoft/dotnet-framework-samples |
There was a problem hiding this comment.
I just noticed we don't document what latest refers to here as well as the .NET Core samples.
samples/README.md
Outdated
|
|
||
| The samples show various ways to use .NET Framework and Docker together. You can use the samples as the basis of your own Docker images or just to play. | ||
|
|
||
| The samples exercise various levels of functionality. The [.NET Framework Docker sample](dotnetapp/README.md) includes the most functionality, including build, unit testing, and pushing images to a container registry. The [ASP.NET Core Docker sample](aspnetapp/README.md) includes instructions for testing images with [Azure Container Instances](https://azure.microsoft.com/services/container-instances/). The samples include detailed instructions for use with and without Docker. |
There was a problem hiding this comment.
I see a lot of Core refernces throughout the docs.
There was a problem hiding this comment.
Yes. Those are the docs I started with. I think I got most of the "Core" references.
| The instructions assume that you are in the root of the repository. | ||
|
|
||
| ```console | ||
| docker run --rm -it -v c:\git\dotnet-docker\samples\dotnetapp:c:\app\ -w \app\dotnetapp microsoft/dotnet-framework:4.7.2-sdk dotnet watch run |
There was a problem hiding this comment.
dotnet-docker reference should be dotnet-framework-docker
Samples exist in https://github.com/microsoft/dotnet-framework-docker-samples/ today. We're going to close that repo, just like we did with https://github.com/dotnet/dotnet-docker-samples/.