Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Remove Dev Diagnostics Experimental Feature #3955

Merged
krschau merged 3 commits into from
Oct 28, 2024
Merged

Remove Dev Diagnostics Experimental Feature #3955

krschau merged 3 commits into from
Oct 28, 2024

Conversation

@krschau
Copy link
Collaborator

@krschau krschau commented Oct 22, 2024

Summary of the pull request

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@jaholme
Copy link
Contributor

jaholme commented Oct 22, 2024 

  </Extensions>

This should also go as well. It was a part of Dev Diagnostics

Refers to: src/Package-Dev.appxmanifest:399 in 0c4e347. [](commit_id = 0c4e347, deletion_comment = False)

@jaholme
Copy link
Contributor

jaholme commented Oct 22, 2024 

<ProjectReference Include="..\tools\Utilities\RegPreviewUtility\DevHome.RegistryPreview.csproj" />

this was a piece of devdiagnostics not utilties

Refers to: src/DevHome.csproj:108 in 0c4e347. [](commit_id = 0c4e347, deletion_comment = False)

@dabhattimsft
Copy link
Contributor

dabhattimsft commented Oct 22, 2024 

<ProjectReference Include="..\tools\Utilities\RegPreviewUtility\DevHome.RegistryPreview.csproj" />

IfeoTool?

In reply to: 2430464513

Refers to: src/DevHome.csproj:108 in 0c4e347. [](commit_id = 0c4e347, deletion_comment = False)

@jaholme
Copy link
Contributor

jaholme commented Oct 23, 2024 

<ProjectReference Include="..\tools\Utilities\RegPreviewUtility\DevHome.RegistryPreview.csproj" />

yes ifeotool

In reply to: 2430489509

Refers to: src/DevHome.csproj:108 in 0c4e347. [](commit_id = 0c4e347, deletion_comment = False)

@jaholme
Copy link
Contributor

jaholme commented Oct 23, 2024 

<ProjectReference Include="..\service\DevHome.Service\DevHome.Service.csproj" />

The NT service should go as well, it was only used by devdiagnostics

Refers to: src/DevHome.csproj:87 in 0c4e347. [](commit_id = 0c4e347, deletion_comment = False)

jaholme
jaholme reviewed Oct 23, 2024
View reviewed changes
jaholme
jaholme reviewed Oct 23, 2024
View reviewed changes
@krschau krschau merged commit c3b1703 into main Oct 28, 2024
@krschau krschau added this to the Dev Home v0.19 milestone Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andreww-msft andreww-msft Awaiting requested review from andreww-msft

@timkur timkur Awaiting requested review from timkur

@lauren-ciha lauren-ciha Awaiting requested review from lauren-ciha

3 more reviewers

@guimafelipe guimafelipe guimafelipe approved these changes

@jaholme jaholme jaholme approved these changes

@EricJohnson327 EricJohnson327 EricJohnson327 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Dev Home v0.19

Development

Successfully merging this pull request may close these issues.

6 participants

@krschau @jaholme @dabhattimsft @guimafelipe @EricJohnson327