This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Update theme of Add Widget dialog when system theme changes #2407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmelBawa-msft
approved these changes
Mar 14, 2024
tools/Dashboard/DevHome.Dashboard/ViewModels/AddWidgetViewModel.cs
Outdated
Show resolved
Hide resolved
| { | ||
| foreach (var widgetItem in providerItem.MenuItems.Cast<NavigationViewItem>()) | ||
| { | ||
| var widgetDefinition = widgetItem.Tag as WidgetDefinition; |
Contributor
There was a problem hiding this comment.
Do we need to try catch widget definition usage, or we don't expect RPC errors here?
Collaborator
Author
There was a problem hiding this comment.
Technically yes, I think we should, but I think the only way to do this without making the whole dashboard a mess of try/catches is to wrap the widget objects in a model so we don't have to be querying the real objects the entire time (which I do plan to do at some point).
dhoehna
reviewed
Mar 15, 2024
tools/Dashboard/DevHome.Dashboard/Views/AddWidgetDialog.xaml.cs
Outdated
Show resolved
Hide resolved
dhoehna
reviewed
Mar 15, 2024
tools/Dashboard/DevHome.Dashboard/Views/AddWidgetDialog.xaml.cs
Outdated
Show resolved
Hide resolved
…ther than passing it in
7147f08 to
09ecc5e
Compare
vineeththomasalex
approved these changes
Mar 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
If the user updated the system theme while the Add Widget dialog was open, the dialog would not update. This change fixes the problem by:
This change has the nice side-effect of decoupling the AddWidgetView and the DashboardView, by requiring the DashboardView to pass in the dispatcherQueue or ActualTheme anymore. It will also make it easier to move more logic from the AddWidget View to ViewModel in the future if we want to.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist