Skip to content

Require new packages for TS interdependencies #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jfullerton44 merged 7 commits into from
Jan 9, 2024
Merged

Require new packages for TS interdependencies #358

jfullerton44 merged 7 commits into from
Jan 9, 2024

Conversation

@jfullerton44
Copy link
Collaborator

@jfullerton44 jfullerton44 commented Dec 4, 2023

Fixes #

Changes proposed:

  • Requires that TS packages use the newest version of the other packages when imported. This fixes the issue where yarn can import multiple version of the contracts packages

IlyaBiryukov
IlyaBiryukov reviewed Dec 4, 2023
View reviewed changes
IlyaBiryukov
IlyaBiryukov reviewed Dec 4, 2023
View reviewed changes
@jfullerton44 jfullerton44 enabled auto-merge (squash) December 5, 2023 16:25
@jfullerton44 jfullerton44 merged commit d7e1e3a into main Jan 9, 2024
@jfullerton44 jfullerton44 deleted the dev/jfullerton/tsPackageVersion branch January 9, 2024 18:16
@jfullerton44 jfullerton44 mentioned this pull request Jan 10, 2024
Merged
2 tasks
@jramsay jramsay mentioned this pull request Jan 22, 2024
Merged
1 task
@osortega osortega mentioned this pull request Jan 24, 2024
Closed
2 tasks
This was referenced Jan 24, 2024
Merged
Merged
Merged
@jfullerton44 jfullerton44 mentioned this pull request Jan 29, 2024
Merged
2 tasks
This was referenced Jan 29, 2024
Merged
Merged
@jfullerton44 jfullerton44 mentioned this pull request Jan 29, 2024
Merged
2 tasks
@jramsay jramsay mentioned this pull request Jan 31, 2024
Merged
2 tasks
@connor4312 connor4312 mentioned this pull request Jan 31, 2024
Merged
2 tasks
@taiyosogawa taiyosogawa mentioned this pull request Feb 6, 2024
Merged
2 tasks
@jfullerton44 jfullerton44 mentioned this pull request Feb 15, 2024
Merged
2 tasks
@neelip neelip mentioned this pull request Feb 22, 2024
Merged
2 tasks
@dmgardiner25 dmgardiner25 mentioned this pull request Feb 28, 2024
Closed
2 tasks
@jramsay jramsay mentioned this pull request Mar 4, 2024
Merged
1 task
@connor4312 connor4312 mentioned this pull request Mar 6, 2024
Merged
2 tasks
This was referenced Mar 7, 2024
Closed
Merged
@JacobRoberts JacobRoberts mentioned this pull request Mar 8, 2024
Merged
2 tasks
@jramsay jramsay mentioned this pull request Mar 11, 2024
Merged
@jfullerton44 jfullerton44 mentioned this pull request Oct 17, 2024
Closed
@williammartin williammartin mentioned this pull request Jul 2, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IlyaBiryukov IlyaBiryukov IlyaBiryukov left review comments

@klvnraju klvnraju klvnraju approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jfullerton44 @IlyaBiryukov @klvnraju