Fix #156: Add a flag for the old way of handling args from a launch config#230
Merged
int19h merged 1 commit intomicrosoft:masterfrom May 7, 2020
Merged
Fix #156: Add a flag for the old way of handling args from a launch config#230int19h merged 1 commit intomicrosoft:masterfrom
int19h merged 1 commit intomicrosoft:masterfrom
Conversation
… launch config Add new property "argsExpansion", which defaults to "shell", but can be explicitly set to "none" to request no expansion. Propagate "args" to launcher via CLI or JSON, depending on the value of "argsExpansion". Move the logic to compute process name back to the adapter, alongside other processing of "launch" targets.
|
Kudos, SonarCloud Quality Gate passed!
|
karthiknadig
reviewed
May 7, 2020
|
|
||
| args += request("args", json.array(unicode)) | ||
| # Propagate "args" via CLI if and only if shell expansion is requested. | ||
| args_expansion = request("argsExpansion", json.enum("shell", "none", optional=True)) |
Member
There was a problem hiding this comment.
Do we need to expose this in the extension? to provide completion or do we want to keep it internal.
Contributor
Author
There was a problem hiding this comment.
I think it's best to expose. Some users might need the old behavior, and without this flag, it's just not possible.
karthiknadig
approved these changes
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new property "argsExpansion", which defaults to "shell", but can be explicitly set to "none" to request no expansion.
Propagate "args" to launcher via CLI or JSON, depending on the value of "argsExpansion".
Move the logic to compute process name back to the adapter, alongside other processing of "launch" targets.