Skip to content

Missing requirement to have "request": "launch" or "request": "attach" in new startDebugging request #333

New issue
New issue
Closed
Closed
Missing requirement to have "request": "launch" or "request": "attach" in new startDebugging request#333
Assignees
roblourens
@jonahgraham

Description

@jonahgraham
jonahgraham
opened on Sep 13, 2022

IIUC In this comment #79 (comment) the startDebugging was specified to require "request": "launch" or "request": "attach" fields. Without them the receiver cannot distinguish if the startDebugging is for launch or attach.

As far as I understand these fields aren't specified here:

debug-adapter-protocol/debugAdapterProtocol.json

Lines 828 to 840 in 1f0a81b

"StartDebuggingRequestArguments": {
"type": "object",
"description": "Arguments for `startDebugging` request.",
"properties": {
"configuration": {
"oneOf": [
{ "$ref": "#/definitions/LaunchRequestArguments" },
{ "$ref": "#/definitions/AttachRequestArguments" }
],
"description": "Arguments passed to the new debug session. The arguments must only contain properties understood by the `launch` or `attach` requests of the debug adapter and they must not contain any client-specific properties (e.g. `type`) or client-specific features (e.g. substitutable 'variables')."
}
},
"required": [ "configuration" ]

Therefore this issue is to request that request field be made required in StartDebuggingRequestArguments

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions