Fix the exception type/message for when we encounter an uninitialized runtime or truncated dump#1395
Merged
leculver merged 1 commit intomicrosoft:mainfrom Feb 26, 2026
Merged
Conversation
Change the Heap property exception from NotSupportedException to InvalidDataException with an actionable message explaining that the CLR may not have been fully initialized or the dump may be corrupt/truncated. Update the existing DacVersion and AppDomainStoreData error messages in DacRuntime.cs to include the same guidance, giving users consistent actionable information across all failure modes. Fixes dotnet/diagnostics#5717 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
noahfalk
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the exception thrown when GC heap data structures cannot be loaded from NotSupportedException to ClrDiagnosticsException. The new message explains that the CLR may not have been fully initialized or the dump may be corrupt/truncated, instead of the unhelpful 'Unable to create a ClrHeap for this runtime.'
Fixes dotnet/diagnostics#5717
Fixes dotnet/diagnostics#2197