Null fields should have the correct type#1377
Merged
leculver merged 2 commits intomicrosoft:mainfrom Feb 20, 2026
Merged
Conversation
When ReadObjectField reads a null pointer (obj == 0), use the field's declared type instead of looking up the heap, which would return ErrorType. For non-null objects, continue reading the actual runtime type from the heap to preserve polymorphism. Fixes microsoft#1342. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Verifies that ReadObjectField returns the field's declared type (SamplePointerType) when the field value is null, rather than ErrorType. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
while we are here, I noticed that null value is reported as 'invalid'. IsValid returns false. |
Contributor
Author
|
That might be a bit confusing but it's meant to be that way. |
brianrob
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue raised in #1370. Null fields shouldn't use GetObject(null) because that does not properly set the type.