Fix GetFieldByName to return derived class field when names are shadowed#1371
Merged
leculver merged 1 commit intomicrosoft:mainfrom Feb 18, 2026
Merged
Fix GetFieldByName to return derived class field when names are shadowed#1371leculver merged 1 commit intomicrosoft:mainfrom
leculver merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in GetFieldByName where it would incorrectly return a base class field instead of a derived class field when both classes declare fields with the same name. The fix changes from FirstOrDefault to LastOrDefault to match C# field shadowing semantics, where the most-derived field should be returned.
Changes:
- Modified
ClrDacType.GetFieldByNameto useLastOrDefaultinstead ofFirstOrDefault, ensuring the most-derived field is returned when field names are shadowed in inheritance hierarchies
Changed FirstOrDefault to LastOrDefault in both ClrDacType and ClrStringType so that the most-derived field is returned when base and derived classes have fields with the same name. Fixes microsoft#1370.
steveisok
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a derived class declares a field with the same name as a base class field, GetFieldByName was returning the base class field because Fields is ordered base-first and FirstOrDefault picks the first match.
Changed to LastOrDefault so the most-derived field is returned, matching C# shadowing semantics. Fixes #1370.