Allow users to paste expressions with ^ (power) or % (modulo)#682
Merged
EriWong merged 1 commit intomicrosoft:masterfrom Oct 18, 2019
rudyhuyn:Fix299
Merged
Allow users to paste expressions with ^ (power) or % (modulo)#682EriWong merged 1 commit intomicrosoft:masterfrom rudyhuyn:Fix299
EriWong merged 1 commit intomicrosoft:masterfrom
rudyhuyn:Fix299
Conversation
EriWong
suggested changes
Oct 15, 2019
Contributor
EriWong
left a comment
There was a problem hiding this comment.
The change looks good. I think you'll need to resubmit after resolving the merge conflicts though.
EriWong
approved these changes
Oct 18, 2019
Contributor
EriWong
left a comment
There was a problem hiding this comment.
Looks good. Thanks for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #299 and #674
Add support of
%for Scientific and Programmer modeAdd support of
^for Scientific modeDescription of the changes:
StandardCalculatorViewModel::MapCharacterToButtonIdto support the 2 new charactersCopyPasteManager::ExtractOperandsHow changes were validated:
Manually