Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

feat: add support for Teams meeting start/end events #3757

Merged
mdrichardson merged 16 commits into from
Jun 18, 2021
Merged

feat: add support for Teams meeting start/end events #3757

mdrichardson merged 16 commits into from
Jun 18, 2021

Conversation

@mdrichardson
Copy link
Contributor

@mdrichardson mdrichardson commented Jun 16, 2021 •
edited
Loading

Fixes #3724

Description

Adds support to TeamsActivityHandler for meeting start/end events.

Notes

Bots implementing this must add this to their manifest.json:

"webApplicationInfo": {
        "id": "<MicrosoftAppId>",
        "resource": "<urlToApp>",
        "applicationPermissions": [
            "OnlineMeeting.ReadBasic.Chat"
        ]
    }

Note that somebody needs to actually start/join the meeting for this to work. The scheduled start/end times mean nothing for this event.

Testing

image

@mdrichardson mdrichardson changed the title [Draft] add support for Teams meeting start/end events [Draft] feat: add support for Teams meeting start/end events Jun 16, 2021
@coveralls
Copy link

coveralls commented Jun 16, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 951068226

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 85.418%
Totals Coverage Status
Change from base Build 950796702: 0.006%
Covered Lines: 19296
Relevant Lines: 21490
💛 - Coveralls

@mdrichardson mdrichardson changed the title [Draft] feat: add support for Teams meeting start/end events feat: add support for Teams meeting start/end events Jun 16, 2021
mdrichardson
mdrichardson commented Jun 16, 2021
View reviewed changes
libraries/botbuilder/src/teamsActivityHandler.ts Outdated
Comment on lines 1011 to 1012
// The payload from Teams comes in with TitleCase keys, so we'll convert them to camelCase
// to maintain JSON and JS standard practices.
Copy link
Contributor Author

@mdrichardson mdrichardson Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This is intentional from Teams and not expected to change.

mdrichardson
mdrichardson commented Jun 16, 2021
View reviewed changes
libraries/botframework-schema/src/teams/index.ts
* Specific details of a Teams meeting.
*/
export interface MeetingDetails {
interface MeetingDetailsBase {
Copy link
Contributor Author

@mdrichardson mdrichardson Jun 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: These interfaces were originally introduced in the PR that added getMeetingInfo(). Per Teams, the two schemas are intentionally different in the ways depicted below and not likely to change.

mdrichardson
mdrichardson commented Jun 17, 2021
View reviewed changes
@mdrichardson mdrichardson marked this pull request as ready for review June 17, 2021 18:02
@mdrichardson mdrichardson requested a review from a team as a code owner June 17, 2021 18:02
@mdrichardson mdrichardson mentioned this pull request Jun 17, 2021
Closed
12 tasks
mdrichardson
mdrichardson commented Jun 17, 2021
View reviewed changes
mdrichardson
mdrichardson commented Jun 17, 2021
View reviewed changes
joshgummersall
joshgummersall reviewed Jun 18, 2021
View reviewed changes
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor things, and a suggestion to use runtypes if you want.

joshgummersall
joshgummersall reviewed Jun 18, 2021
View reviewed changes
@mdrichardson mdrichardson requested a review from stevengum as a code owner June 18, 2021 19:11
@mdrichardson mdrichardson merged commit b4d2312 into microsoft:main Jun 18, 2021
@mdrichardson mdrichardson deleted the teamsMeetingEvents branch June 18, 2021 21:44
@mdrichardson mdrichardson mentioned this pull request Jun 21, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stevengum stevengum Awaiting requested review from stevengum

1 more reviewer

@joshgummersall joshgummersall joshgummersall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Teams - meeting start/end events (JS)

3 participants

@mdrichardson @coveralls @joshgummersall