Skip to content

python3: Remove Windows execuatables, add add'l provides#3286

Merged
oliviacrain merged 1 commit intomainfrom
olivia/py3-exe
Jul 2, 2022
Merged

python3: Remove Windows execuatables, add add'l provides#3286
oliviacrain merged 1 commit intomainfrom
olivia/py3-exe

Conversation

@oliviacrain
Copy link
Copy Markdown
Contributor

@oliviacrain oliviacrain commented Jul 1, 2022

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

This PR addresses two issues with our Python 3 package:

Issue 1: We're shipping Windows executables in our pip and setuptools subpackages. These are not necessary for the functions of these packages in the Mariner context. So, let's remove them to reduce bloat.

Issue 2: Per customer feedback, we want to provide names in the style of python%{majmin}-%{subpackage} and python%{majmin_nodots}-%{subpackage} to match Fedora's package names.

Fixes #3058

Change Log
  • Remove Windows executables from pip, setuptools subpackages
  • Add additional provides in the style of python%{majmin}-%{subpackage} and python%{majmin_nodots}-%{subpackage}
  • Note: Not adding additional provides for pip, setuptools subpackages. There are no equivalent majmin-versioned names in Fedora.
Does this affect the toolchain?

YES

Test Methodology
  • Delta toolchain build. Confirmed Windows executables are no longer present, and that the wanted provides are added

@ghost ghost added the main PR Destined for main label Jul 1, 2022
@oliviacrain oliviacrain marked this pull request as ready for review July 1, 2022 20:15
@oliviacrain oliviacrain requested a review from a team as a code owner July 1, 2022 20:15
Copy link
Copy Markdown
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@oliviacrain oliviacrain merged commit c9cb85e into main Jul 2, 2022
@oliviacrain oliviacrain deleted the olivia/py3-exe branch July 2, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Mariner's tdnf repo should have specific versions of Python - python39

2 participants