Filter out candidates with the same name but different instructions, …#925
Merged
Conversation
…file IDs, and function names
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
===========================================
+ Coverage 30.23% 57.13% +26.90%
===========================================
Files 30 30
Lines 3989 4020 +31
Branches 899 957 +58
===========================================
+ Hits 1206 2297 +1091
+ Misses 2704 1512 -1192
- Partials 79 211 +132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gagb
reviewed
Dec 10, 2023
Collaborator
|
See this PR: Otherwise looks good |
gagb
approved these changes
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Filter out candidates with the same name but different instructions, file IDs, and function names.
Related issue number
Refer #892
Checks