Skip to content

add a way to provide extra grpc options#3667

Merged
jackgerrits merged 6 commits into
microsoft:stagingfrom
MohMaz:feat-add-grpc-message-size
Oct 8, 2024
Merged

add a way to provide extra grpc options#3667
jackgerrits merged 6 commits into
microsoft:stagingfrom
MohMaz:feat-add-grpc-message-size

Conversation

@MohMaz

@MohMaz MohMaz commented Oct 5, 2024

Copy link
Copy Markdown
Contributor

Why are these changes needed?

  1. Updates worker runtime and host so the user can pass more custom grpc options for channel
  2. Test added to verify the max message length configuration
  3. Cleans up MyAgent and MyMessage classes

Related issue number

Closes #3648

Checks

@MohMaz MohMaz marked this pull request as ready for review October 5, 2024 10:16
@MohMaz

MohMaz commented Oct 5, 2024

Copy link
Copy Markdown
Contributor Author

@ekzhu can you please review and provide feedback?

Comment thread python/packages/autogen-core/tests/test_utils/__init__.py Outdated
Comment thread python/packages/autogen-core/tests/test_utils/__init__.py Outdated
Comment thread python/packages/autogen-core/tests/test_utils/__init__.py Outdated
Comment thread python/packages/autogen-core/src/autogen_core/application/_worker_runtime_host.py Outdated
@ekzhu ekzhu requested a review from jackgerrits October 5, 2024 15:43
@MohMaz MohMaz force-pushed the feat-add-grpc-message-size branch from 4d11f5f to 0a7bc76 Compare October 5, 2024 17:52
@MohMaz MohMaz requested a review from ekzhu October 5, 2024 18:24
Comment thread python/packages/autogen-core/src/autogen_core/application/_worker_runtime.py Outdated
Comment thread python/packages/autogen-core/src/autogen_core/application/_worker_runtime.py Outdated
@jackgerrits

Copy link
Copy Markdown
Contributor

Can you add an FAQ for "How do I increase the GRPC message size?"

@MohMaz MohMaz changed the title add a way to provide more grpc options add a way to provide extra grpc options Oct 7, 2024
@MohMaz MohMaz requested a review from jackgerrits October 7, 2024 23:11
@jackgerrits jackgerrits merged commit 29c23d5 into microsoft:staging Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants