Add RemoteAgent and Receiver#1289
Closed
jackgerrits wants to merge 5 commits into
Closed
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1289 +/- ##
==========================================
+ Coverage 32.08% 41.82% +9.73%
==========================================
Files 32 35 +3
Lines 4394 4512 +118
Branches 1025 1090 +65
==========================================
+ Hits 1410 1887 +477
+ Misses 2867 2476 -391
- Partials 117 149 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… Fix a missing function in remote agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof of concept of one way agents could communicate remotely. In the current design, the app must know the host and port of each remote agent it must be able to communicate with. This could in time be replaced with some kind of distributed directory (or just DNS).
Since I only implemented the
Agentinterface, there were a few issues found where theAgenttype is used, but there are more requirements than just this type. Such as the following methods being requiredreset_consecutive_auto_reply_counter,reply_at_receive,clear_historyIt also currently uses HTTP calls to send messages and uses Python's
http.servermodule which definitely should not be used in production. It should be replaced with either a different server, or a different technology entirely.ZMQ,GPRCetcKnown issues:
Termination does not work correctlyRequestReply is hardcoded to true by the receiver(hacky support for "TERMINATE" added)TODO:
Example of two remote agents coordinating to determine a common meeting time for two users:

Screen.Recording.2024-01-18.at.10.11.05.AM.mov
First two turns:
