Switched to AzureOpenAI for api_type=="azure"#1232
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1232 +/- ##
==========================================
+ Coverage 31.95% 41.81% +9.85%
==========================================
Files 33 33
Lines 4431 4415 -16
Branches 1035 1085 +50
==========================================
+ Hits 1416 1846 +430
+ Misses 2897 2421 -476
- Partials 118 148 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sonichi
reviewed
Jan 13, 2024
Contributor
|
Could you fix the conflict? We are close to ready. |
Contributor
Author
|
@sonichi , I had to return the model names workaround to fix tests using get-3.5-instruct, without the fix the tests are not runnable with azure models 
|
Contributor
Pushed a change that should fix this. |
Contributor
Author
Looks good, tests pass |
sonichi
approved these changes
Jan 17, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With version 1 of
openaiclient library there's a dedicated classAzureOpenAIto handle Azure endpoints. While the current version had a cryptic_process_for_azureworkaround likely coming from pre v1 times it makes sense to remove the old code and hand over the responsibility of interacting with Azure straight toopenailibrary/Checks
! I still don't have all the endpoints to completely run OpenAI tests, yet those few that ran before the change kept running after it.