Skip to content

Move remaining ACA infrastructure generation to Aspire.Hosting.Azure.AppContainers#7970

Merged
davidfowl merged 28 commits into
mainfrom
davidfowl/resources-bicep
Mar 18, 2025
Merged

Move remaining ACA infrastructure generation to Aspire.Hosting.Azure.AppContainers#7970
davidfowl merged 28 commits into
mainfrom
davidfowl/resources-bicep

Conversation

@davidfowl

@davidfowl davidfowl commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

Description

This change introduces a new AzureContainerAppsEnviromentResource that represents an Azure Container App environment. The goal is to move all of the generated infrastructure to the app host and out of azd. This allows users to model and tweak most things to do with deployment in C#, instead of dropping to bicep via infra synth.

Fixes #7076

@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 10, 2025
@davidfowl davidfowl changed the title Davidfowl/resources bicep Move remaining ACA infrastructure generation to Aspire.Hosting.Azure.AppContainers Mar 10, 2025
Comment thread src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppExtensions.cs Outdated
Comment thread src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppEnvironmentResource.cs Outdated
Comment thread playground/AzureContainerApps/AzureContainerApps.AppHost/Program.cs Outdated
Comment thread playground/AzureContainerApps/AzureContainerApps.AppHost/Program.cs Outdated
Comment thread playground/AzureContainerApps/AzureContainerApps.AppHost/Program.cs Outdated
@davidfowl davidfowl force-pushed the davidfowl/resources-bicep branch from 064e9a8 to 0d9cf80 Compare March 15, 2025 18:36
@davidfowl davidfowl force-pushed the davidfowl/resources-bicep branch from 8d1cde9 to 3e23059 Compare March 16, 2025 23:38
Comment thread playground/AzureContainerApps/AzureContainerApps.AppHost/infra/main.bicep Outdated
Comment thread src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppsInfrastructure.cs Outdated
Comment thread src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppExtensions.cs Outdated
Comment thread src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppExtensions.cs Outdated
Comment thread src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppsInfrastructure.cs Outdated
@davidfowl davidfowl marked this pull request as ready for review March 18, 2025 05:04
@davidfowl

Copy link
Copy Markdown
Contributor Author

This is ready for review again @eerhardt @mitchdenny

@eerhardt eerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in.

@davidfowl davidfowl enabled auto-merge (squash) March 18, 2025 16:47
@davidfowl davidfowl merged commit 62d3fe0 into main Mar 18, 2025
@davidfowl davidfowl deleted the davidfowl/resources-bicep branch March 18, 2025 16:58
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move remaining ACA infrastructure generation to Aspire.Hosting.Azure.AppContainers

5 participants