[main] Update dependencies from dotnet/arcade#5682
[main] Update dependencies from dotnet/arcade#5682dotnet-maestro[bot] merged 14 commits intomainfrom
Conversation
…909.6 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24453.1 -> To Version 9.0.0-beta.24459.6
Fix `Multiple top-level headings in the same document [Context: "# Development notes"]`. PR opened upstream - dotnet/arcade#15082 .
…913.2 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24459.6 -> To Version 9.0.0-beta.24463.2
|
@radical - it looks like the template tests are failing in both the windows and linux legs. |
…916.2 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24463.2 -> To Version 9.0.0-beta.24466.2
| // Avoid using the msbuild terminal logger, so the output can be read | ||
| // in the tests | ||
| EnvVars["VsTestUseMSBuildOutput"] = "false"; | ||
| EnvVars["MSBUILDENSURESTDOUTFORTASKPROCESSES"] = "1"; |
There was a problem hiding this comment.
@baronfel @rainersigwald - should this just happen automatically in CI?
There was a problem hiding this comment.
dotnet test should be doing this for you if you use an invocation of it that requires this flag: https://github.com/dotnet/sdk/blob/176e8ca72f5b9111649c49ca43a71d1dd9904bd0/src/Cli/dotnet/commands/dotnet-test/Program.cs#L61
In general MSBuild should not allow worker nodes to stomp all over the central nodes' stdout, VSTest is doing a bad here.
There was a problem hiding this comment.
The reason I'm adding this here is to avoid the terminal logger. The first one didn't seem to be enough. Do I need to explicitly set _MSBUILDTLENABLED=0?
There was a problem hiding this comment.
Since rc1 (IIRC) the dotnet test output is tied to the terminal logger status. When Terminal Logger is off the new output is also off. MSBUILDTLENABLED=0 or -tl:false should be enough to disable the new output.
…96-4d1d-b4a7-2ceefe4f33e0
…96-4d1d-b4a7-2ceefe4f33e0 # Conflicts: # tests/Shared/WorkloadTesting/BuildEnvironment.cs
|
@microsoft-github-policy-service rerun |
| EnvVars["DEBUG_SESSION_PORT"] = ""; | ||
| // Avoid using the msbuild terminal logger, so the output can be read | ||
| // in the tests | ||
| EnvVars["_MSBUILDTLENABLED"] = "0"; |
There was a problem hiding this comment.
- Why is this start with an underscore?
- Do we need to set both this and VsTest? I thought VS test gets turned off when msbuild is turned off.
There was a problem hiding this comment.
- Why is this start with an underscore?
I'm not sure. Maybe the msbuild team intends this to be a private, and temporary knob.
- Do we need to set both this and VsTest? I thought VS test gets turned off when msbuild is turned off.
Looks like this might fixed in newer SDKs - https://github.com/microsoft/vstest/blob/4f16fc041b85e102c7ee783ed4124d733d067c74/src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.targets#L32-L33
This is what I have in 9.0.100-preview.7.24407.12:
<Target Name="VSTest" DependsOnTargets="ShowInfoMessageIfProjectHasNoIsTestProjectProperty">
<!-- Unloggable colorized output (cf. https://github.com/microsoft/vstest/issues/680) -->
<CallTarget Targets="_VSTestConsole" Condition="!$(VsTestUseMSBuildOutput) OR $(MSBUILDENSURESTDOUTFORTASKPROCESSES) == '1'" />
<!-- Proper MSBuild integration, but no custom colorization -->
<CallTarget Targets="_VSTestMSBuild" Condition="$(VsTestUseMSBuildOutput)" />
</Target>There was a problem hiding this comment.
Maybe the msbuild team intends this to be a private, and temporary knob.
Yes and it's also an output of MSBuild not an input, so I don't think I understand what's happening here.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
Microsoft Reviewers: Open in CodeFlow